Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Dec 20, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Extended test skip list to improve test suite management.

Note: This release contains internal testing infrastructure updates only. No user-facing features or bug fixes included.

✏️ Tip: You can customize this high-level summary in your review settings.

@jieli-matrix jieli-matrix self-assigned this Dec 22, 2025
@jieli-matrix jieli-matrix force-pushed the user/qa/post_update_waive_20251221_LLM_FUNCTION_TEST_1774 branch from fd6bde5 to 5384206 Compare December 22, 2025 05:46
@jieli-matrix jieli-matrix marked this pull request as ready for review December 22, 2025 05:47
@jieli-matrix jieli-matrix enabled auto-merge (squash) December 22, 2025 05:47
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 22, 2025

📝 Walkthrough

Walkthrough

Updates the test skip metadata by adding multiple SKIP entries to the waives.txt integration test list. No functional code changes or control flow modifications are present; only test skip configuration increases.

Changes

Cohort / File(s) Change Summary
Test Skip Metadata
tests/integration/test_lists/waives.txt
Adds multiple SKIP entries to extend the list of integration tests to skip during testing

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify that added test identifiers are correctly formatted and correspond to actual failing tests
  • Confirm that SKIP entries don't unintentionally mask legitimate test failures

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal and lacks required sections from the template such as Description, Test Coverage, and PR Checklist completeness. Expand the description to include: detailed explanation of which test cases failed and why they are being waived, test coverage details, and completion of the PR checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding failed cases to the waives.txt file, which matches the changeset perfectly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 237fd0e and 5384206.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-29T14:07:45.863Z
Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/test_lists/waives.txt (1)

492-501: All new waiver entries follow established format and are properly structured.

The added test skip entries (lines 492–501) consistently follow the existing format with proper test identifiers, SKIP markers, and referenced bug numbers. The entries for DeepSeekV3Lite variants (492–500) are correctly grouped under the same bug reference (5759338), and the final entry (501) is properly linked to its respective bug. Based on learnings, having tests in waives.txt alongside other test list files is intentional—tests remain part of test suites but are skipped due to these waivers.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251221_LLM_FUNCTION_TEST_1774 branch from 5384206 to 284ffe9 Compare December 22, 2025 07:23
@jieli-matrix
Copy link
Collaborator

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29521 [ run ] triggered by Bot. Commit: 36c06e2

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29521 [ run ] completed with state FAILURE. Commit: 36c06e2
/LLM/main/L0_MergeRequest_PR pipeline #22699 (Partly Tested) completed with status: 'ABORTED'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@LarryXFly LarryXFly disabled auto-merge December 23, 2025 05:43
@LarryXFly LarryXFly merged commit 77b591f into NVIDIA:main Dec 23, 2025
4 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20251221_LLM_FUNCTION_TEST_1774 branch December 23, 2025 05:52
JunyiXu-nv pushed a commit to JunyiXu-nv/TensorRT-LLM that referenced this pull request Dec 30, 2025
Signed-off-by: xinhe-nv <[email protected]>
Signed-off-by: Jie Li <[email protected]>
Signed-off-by: Jie Li <[email protected]>
Co-authored-by: Jie Li <[email protected]>
Co-authored-by: Jie Li <[email protected]>
Co-authored-by: Larry Xu <[email protected]>
videodanchik pushed a commit to videodanchik/TensorRT-LLM that referenced this pull request Jan 14, 2026
Signed-off-by: xinhe-nv <[email protected]>
Signed-off-by: Jie Li <[email protected]>
Signed-off-by: Jie Li <[email protected]>
Co-authored-by: Jie Li <[email protected]>
Co-authored-by: Jie Li <[email protected]>
Co-authored-by: Larry Xu <[email protected]>
Signed-off-by: Daniil Kulko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants