Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Jan 6, 2026

waive failed cases.

Summary by CodeRabbit

Tests

  • Added skip waiver for GPU parallel embedding test case with float16 data type configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20260106_LLM_FUNCTION_TEST_1795 branch from 9e8f116 to dc9358b Compare January 6, 2026 02:25
@xinhe-nv xinhe-nv marked this pull request as ready for review January 6, 2026 02:25
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Jan 6, 2026

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 6, 2026

📝 Walkthrough

Walkthrough

This PR adds a single test case entry to the waiver list for a GPU-specific floating-point embedding test. The change is a straightforward addition to the existing test exception tracking file without modifications to control flow or error handling.

Changes

Cohort / File(s) Summary
Test Waiver List
tests/integration/test_lists/waives.txt
Added one SKIP waiver entry for examples/test_gpt.py::test_llm_gpt2_parallel_embedding_2gpu[float16-0] with bug reference nvbugs/5784518

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal and incomplete. It lacks required sections including a detailed explanation of what and why, test coverage information, and the PR checklist. The description only contains a single brief phrase. Provide a detailed description explaining why these test cases were added to the waives list, which tests are affected, and complete the PR checklist items as applicable.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the primary change—adding failed test cases to the waives.txt file. It is specific, concise, and directly reflects the changeset content.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30654 [ run ] triggered by Bot. Commit: dc9358b

…ION_TEST_1795

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv changed the title [None][chore] Add failed cases into waives.txt [TRTLLM-8638][fix] Add failed cases into waives.txt Jan 6, 2026
@xinhe-nv xinhe-nv enabled auto-merge (squash) January 6, 2026 05:20
…ION_TEST_1795

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
LarryXFly and others added 2 commits January 6, 2026 14:48
…ION_TEST_1795

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@tensorrt-cicd
Copy link
Collaborator

PR_Github #30654 [ run ] completed with state SUCCESS. Commit: dc9358b
/LLM/main/L0_MergeRequest_PR pipeline #23649 (Partly Tested) completed with status: 'SUCCESS'

…ION_TEST_1795

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Jan 6, 2026

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30717 [ reuse-pipeline ] triggered by Bot. Commit: e74404d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30717 [ reuse-pipeline ] completed with state SUCCESS. Commit: e74404d
Reusing PR_Github #30654 (Partly Tested) for commit e74404d

@xinhe-nv xinhe-nv merged commit 704f58d into NVIDIA:main Jan 6, 2026
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20260106_LLM_FUNCTION_TEST_1795 branch January 6, 2026 09:48
videodanchik pushed a commit to videodanchik/TensorRT-LLM that referenced this pull request Jan 14, 2026
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Daniil Kulko <kulkodaniil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants