Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Dec 16, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test suite configuration to skip specific test cases across multiple test suites.

✏️ Tip: You can customize this high-level summary in your review settings.

@xinhe-nv xinhe-nv marked this pull request as ready for review December 16, 2025 07:36
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251216_LLM_FUNCTION_TEST_1753 branch from 95f5605 to 2cbfc20 Compare December 16, 2025 07:37
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

📝 Walkthrough

Walkthrough

This PR updates the test skip configuration in waives.txt by removing existing SKIP entries for specific tests and adding numerous new SKIP entries across accuracy, examples, and CLI/LLM test suites to suppress failing tests during integration test runs.

Changes

Cohort / File(s) Change Summary
Test Skip Configuration
tests/integration/test_lists/waives.txt
Removed select SKIP entries for accuracy/disaggregated tests; added large block of new SKIP entries for test cases across examples, accuracy, and CLI/LLM test suites

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • This is purely a test configuration update with no code logic changes; review primarily involves verifying that the correct test identifiers are listed and formatted consistently

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
  • jieli-matrix
  • StanleySun639

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description 'waive failed cases.' is extremely vague and lacks required sections from the template including detailed explanation of changes, test coverage details, and PR checklist confirmation. Expand the description to explain which tests are being waived and why, provide test coverage details, and complete the PR checklist items as outlined in the template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][chore] Add failed cases into waives.txt' directly and clearly describes the main change: adding failed test cases to the waives.txt file for suppression.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e6187d8 and 95f5605.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-29T14:07:45.863Z
Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

  • tests/integration/test_lists/waives.txt
🔇 Additional comments (1)
tests/integration/test_lists/waives.txt (1)

465-487: Format and structure are consistent with established patterns.

The 23 new test skip entries all follow the established format: test paths, SKIP markers, and bug references for traceability. Each entry references a specific bug in the tracking system (nvbugs URLs), aligning with the operational waiver task scope.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28535 [ run ] triggered by Bot. Commit: 2cbfc20

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251216_LLM_FUNCTION_TEST_1753 branch from 2cbfc20 to 7cfdcbb Compare December 16, 2025 07:46
@tensorrt-cicd
Copy link
Collaborator

PR_Github #28535 [ run ] completed with state FAILURE. Commit: 2cbfc20
/LLM/main/L0_MergeRequest_PR pipeline #21854 (Partly Tested) completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251216_LLM_FUNCTION_TEST_1753 branch from 7cfdcbb to 5bbc623 Compare December 16, 2025 08:05
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@xinhe-nv xinhe-nv enabled auto-merge (squash) December 16, 2025 08:06
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28649 [ run ] triggered by Bot. Commit: 7c7e8fc

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28649 [ run ] completed with state DISABLED
CI server is currently disabled for scheduled maintenance. Estimated completion time: 1 PM PST on 12/16.

@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28713 [ run ] triggered by Bot. Commit: 965d0f1

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28713 [ run ] completed with state FAILURE. Commit: 965d0f1
/LLM/main/L0_MergeRequest_PR pipeline #21964 (Partly Tested) completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251216_LLM_FUNCTION_TEST_1753 branch from 018823c to 61c6be1 Compare December 17, 2025 08:20
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28725 [ run ] triggered by Bot. Commit: 61c6be1

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251216_LLM_FUNCTION_TEST_1753 branch from 61c6be1 to 1f99a7b Compare December 17, 2025 08:43
@tensorrt-cicd
Copy link
Collaborator

PR_Github #28725 [ run ] completed with state SUCCESS. Commit: 61c6be1
/LLM/main/L0_MergeRequest_PR pipeline #21975 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251216_LLM_FUNCTION_TEST_1753 branch from 1f99a7b to 8c12fe2 Compare December 18, 2025 01:25
@xinhe-nv xinhe-nv requested a review from yingguo-trt December 18, 2025 01:41
Signed-off-by: Xin He (SW-GPU) <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251216_LLM_FUNCTION_TEST_1753 branch from 8c12fe2 to 0e584f5 Compare December 18, 2025 02:23
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28886 [ reuse-pipeline ] triggered by Bot. Commit: 0e584f5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28886 [ reuse-pipeline ] completed with state SUCCESS. Commit: 0e584f5
Reusing PR_Github #28725 (Partly Tested) for commit 0e584f5

@xinhe-nv xinhe-nv merged commit 4a98f19 into NVIDIA:main Dec 18, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20251216_LLM_FUNCTION_TEST_1753 branch December 18, 2025 03:17
codego7250 pushed a commit to codego7250/TensorRT-LLM that referenced this pull request Dec 19, 2025
lkomali pushed a commit to lkomali/TensorRT-LLM that referenced this pull request Dec 22, 2025
Signed-off-by: xinhe-nv <[email protected]>
Signed-off-by: Xin He (SW-GPU) <[email protected]>
Signed-off-by: lkomali <[email protected]>
JunyiXu-nv pushed a commit to JunyiXu-nv/TensorRT-LLM that referenced this pull request Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants