Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Dec 31, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test waiver configurations for Llama 3 70B Instruct FP8 Eagle3 TP8 tests with varying configurations to skip specific test variants.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv marked this pull request as ready for review December 31, 2025 06:23
…ION_TEST_1780

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 31, 2025

📝 Walkthrough

Walkthrough

Three new test skip entries are added to the waiver list for Llama 3 70B Instruct FP8 Eagle3 TP8 tests with different eagle3_one_model and torch_compile configurations, each marked with SKIP and associated nvbugs references.

Changes

Cohort / File(s) Summary
Test waiver entries
tests/integration/test_lists/waives.txt
Added six skip entries (three test variants duplicated in two locations) for Llama 3 70B Instruct FP8 Eagle3 TP8 tests with varying eagle3_one_model and torch_compile flag combinations, each marked SKIP with nvbugs references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
  • jieli-matrix
  • StanleySun639

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal and lacks required sections. It does not explain what tests are being waived, why they are being waived, or provide adequate context. Expand the description to explain which specific test cases are being waived and the reason (e.g., nvbugs references, expected fixes).
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: adding failed test cases to the waives.txt file.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30248 [ run ] triggered by Bot. Commit: f7caff7

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30255 [ run ] triggered by Bot. Commit: c51a73a

…ION_TEST_1780

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv enabled auto-merge (squash) December 31, 2025 08:05
@xinhe-nv xinhe-nv changed the title [None][chore] Add failed cases into waives.txt [TRTLLM-8638][fix] Add failed cases into waives.txt Dec 31, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #30255 [ run ] completed with state SUCCESS. Commit: c51a73a
/LLM/main/L0_MergeRequest_PR pipeline #23293 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30278 [ reuse-pipeline ] triggered by Bot. Commit: 721e6e1

@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30280 [ reuse-pipeline ] triggered by Bot. Commit: 2f6cfb5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30278 [ reuse-pipeline ] completed with state ABORTED. Commit: 721e6e1
Can't reuse PR_Github #30255 (Partly Tested) with status: SUCCESS

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30280 [ reuse-pipeline ] completed with state SUCCESS. Commit: 2f6cfb5
Reusing PR_Github #30255 (Partly Tested) for commit 2f6cfb5

@xinhe-nv xinhe-nv merged commit 0d2e271 into NVIDIA:main Dec 31, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20251231_LLM_FUNCTION_TEST_1780 branch December 31, 2025 14:42
videodanchik pushed a commit to videodanchik/TensorRT-LLM that referenced this pull request Jan 14, 2026
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Daniil Kulko <kulkodaniil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants