Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Dec 31, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test configuration to skip a specific test case.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: xinhe-nv <[email protected]>
@xinhe-nv xinhe-nv marked this pull request as ready for review January 5, 2026 06:40
@xinhe-nv xinhe-nv changed the title [None][chore] Add failed cases into waives.txt [TRTLLM-8638][fix] Add failed cases into waives.txt Jan 5, 2026
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Jan 5, 2026

/bot run --skip-test

@xinhe-nv xinhe-nv enabled auto-merge (squash) January 5, 2026 06:41
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 5, 2026

📝 Walkthrough

Walkthrough

A SKIP entry was added to the test waives list for a disaggregated test. This marks test_worker_restart[etcd-round_robin] as skipped. No functional code or control flow changes are involved—only a test status entry was added.

Changes

Cohort / File(s) Summary
Test Configuration
tests/integration/test_lists/waives.txt
Added SKIP entry for disaggregated/test_auto_scaling.py::test_worker_restart[etcd-round_robin]

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • StanleySun639
  • LarryXFly

Pre-merge checks

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal (only "waive failed cases") and lacks required sections from the template like Description, Test Coverage, and PR Checklist details. Expand the description to explain what failed cases are being waived, why they need to be waived, and provide more context about the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding failed test cases to waives.txt, which matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7a4486 and 2bc8d0f.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-29T14:07:45.863Z
Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-09-17T06:01:01.836Z
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7785
File: tests/integration/defs/perf/utils.py:321-333
Timestamp: 2025-09-17T06:01:01.836Z
Learning: In test infrastructure code for disaggregated serving tests, prefer logging errors and continuing execution rather than raising exceptions on timeout, to avoid disrupting test cleanup and causing cascading failures.

Applied to files:

  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/test_lists/waives.txt (1)

544-544: LGTM!

The waiver entry follows the established format and pattern in the file. The test path, SKIP status, and bug reference are all correctly structured.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30560 [ run ] triggered by Bot. Commit: 2bc8d0f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30560 [ run ] completed with state SUCCESS. Commit: 2bc8d0f
/LLM/main/L0_MergeRequest_PR pipeline #23572 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Jan 6, 2026

/bot reuse-pipeline

@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Jan 6, 2026

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30638 [ reuse-pipeline ] triggered by Bot. Commit: f98da84

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30642 [ reuse-pipeline ] triggered by Bot. Commit: a853326

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30638 [ reuse-pipeline ] completed with state ABORTED. Commit: f98da84
Can't reuse PR_Github #30560 (Partly Tested) with status: SUCCESS

@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Jan 6, 2026

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30652 [ reuse-pipeline ] triggered by Bot. Commit: 6f1d746

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30642 [ reuse-pipeline ] completed with state ABORTED. Commit: a853326
Can't reuse PR_Github #30560 (Partly Tested) with status: SUCCESS

@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Jan 6, 2026

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30652 [ reuse-pipeline ] completed with state SUCCESS. Commit: 6f1d746
Reusing PR_Github #30560 (Partly Tested) for commit 6f1d746

@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Jan 6, 2026

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30673 [ reuse-pipeline ] triggered by Bot. Commit: 8a2ba66

@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Jan 6, 2026

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30681 [ reuse-pipeline ] triggered by Bot. Commit: 4d64c7a

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30681 [ reuse-pipeline ] completed with state SUCCESS. Commit: 4d64c7a
Reusing PR_Github #30560 (Partly Tested) for commit 4d64c7a

@xinhe-nv xinhe-nv merged commit 9985277 into NVIDIA:main Jan 6, 2026
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20260101_LLM_FUNCTION_TEST_1800 branch January 6, 2026 06:24
videodanchik pushed a commit to videodanchik/TensorRT-LLM that referenced this pull request Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants