Skip to content

chore: nightly sync main into dev (05_05_2026) - #4619

Closed
svcnvidia-nemo-ci wants to merge 86 commits into
devfrom
main2dev/05_05_2026
Closed

chore: nightly sync main into dev (05_05_2026)#4619
svcnvidia-nemo-ci wants to merge 86 commits into
devfrom
main2dev/05_05_2026

Conversation

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

Summary

Nightly automated sync of main into dev (2026-05-05).

  • Brings in 84 commits from main
  • Python lines: +33076 / -5083 across 222 files

Files taken from main (semantic conflicts)

These files have known semantic conflicts where dev's versions reference args
or APIs main has removed/renamed. Taken from main wholesale:

  • megatron/training/training.py
  • megatron/training/initialize.py
  • megatron/training/utils.py
  • megatron/training/datasets/data_samplers.py

Files restored from main

  • megatron/core/pipeline_parallel/hybrid_cp_schedule.py — provides
    BalancedCPScheduler, required by main's HybridCPDataLoaderWrapper.
    Dev had renamed it to dynamic_cp_schedule.py and then deleted that
    file in PR [Dev] feat: Dynamic CP (part 2) #2000 ("Dynamic CP part 2") in favor of a new in-place
    scheduler. Restored so main's training code continues to import.

Special handling

  • megatron/core/datasets/data_schedule.py: kept dev's classes
    (BasePackingScheduler, DpBalancedScheduler, DefaultDynamicCPScheduler,
    wrap_data_iterator, get_batch_on_this_rank_for_sequence_packing) and
    appended main's HybridCPDataLoaderWrapper. Imports unioned (Any, List,
    BalancedCPScheduler added).
  • megatron/training/training.py: changed
    if args.hybrid_context_parallel: to
    if getattr(args, 'hybrid_context_parallel', False): since the arg
    no longer exists in dev's arguments.py (replaced by dev's new dynamic
    CP system). The HybridCPDataLoaderWrapper import path remains valid.

Files restored to dev's version

  • .github/CODEOWNERS — sync bot must never modify CODEOWNERS.
  • pyproject.toml — dev includes fast-hadamard-transform git source and
    newer nvidia-resiliency-ext revision.
  • uv.lock — paired with dev's pyproject.toml.
  • docker/Dockerfile.ci.dev — uses --group no_pypi_wheels flag matching
    dev's pyproject.toml.

Conflict resolution summary

-X theirs (favor main) was used as the merge strategy. The full
git show --remerge-diff output is attached below for review.

Files that had genuine merge conflicts (25):

  • .github/workflows/cicd-main.yml
  • docker/Dockerfile.ci.dev (restored to dev)
  • docs/conf.py
  • examples/mimo/train.py
  • megatron/core/datasets/readme.md
  • megatron/core/transformer/moe/fused_a2a.py
  • megatron/core/transformer/moe/moe_layer.py
  • megatron/core/transformer/moe/token_dispatcher.py
  • megatron/core/transformer/transformer_config.py
  • megatron/core/transformer/transformer_layer.py
  • megatron/training/activation_logging.py
  • megatron/training/arguments.py
  • megatron/training/checkpointing.py
  • megatron/training/training.py (taken from main, then patched)
  • megatron/training/utils.py (taken from main)
  • pretrain_bert.py
  • pretrain_gpt.py
  • pretrain_mamba.py
  • pretrain_vlm.py
  • pyproject.toml (restored to dev)
  • tests/unit_tests/models/test_hybrid_moe_model.py
  • tools/checkpoint/checkpoint_inspector.py
  • tools/checkpoint/remap_gpt_dsa_to_mamba.py
  • train_rl.py
  • uv.lock (restored to dev)

Pre-merge formatting

Ran black==24.4.2 (with --skip-magic-trailing-comma --skip-string-normalization)
and isort==5.13.2 on the full set of changed files. pylint==3.2.6 and
ruff~=0.9 produce zero warnings on the autoformat target set.

🤖 Generated by automated nightly sync bot.

minitu and others added 30 commits April 22, 2026 18:02
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: john2 <john2@jrlogin01.jureca>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Co-authored-by: root <root@nvl72098-T17.cm.cluster>
Co-authored-by: William Dykas <wdykas@oci-hsg-cs-001-vscode-03.cm.cluster>
Co-authored-by: root <root@nvl72160-T13.cm.cluster>
…classmethod (#3812)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
#4403)

Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
Co-authored-by: Philip Petrakian <ppetrakian@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ss curve gaps for latent MoE models (#4433)

Signed-off-by: root <jiemingz@nvidia.com>
…4158)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…4422)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: rprenger <rprenger@nvidia.com>
Signed-off-by: qiyuw <qiyuw@nvidia.com>
Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
lmcafee-nvidia and others added 10 commits May 3, 2026 03:51
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: root <root@nvl72114-T04.cm.cluster>
Co-authored-by: root <root@nvl72116-T13.cm.cluster>
Co-authored-by: root <root@nvl72102-T01.cm.cluster>
Co-authored-by: root <root@nvl72150-T11.cm.cluster>
Co-authored-by: root <root@nvl72045-T09.cm.cluster>
Co-authored-by: root <root@nvl72102-T04.cm.cluster>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Asha Anoosheh <aanoosheh@nvidia.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: guihong-nv <guihongl@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented May 5, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added Run functional tests Run MBridge tests Attach this for testing this PR against MBridge main labels May 5, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor Author

/ok to test b187f43

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor Author

/ok to test e879a55

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor Author

/ok to test 4de6661

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor Author

/ok to test 3567666

- Restore moe_expert_rank_capacity_factor field on TransformerConfig (used at
  line 1534 and 1801 but field definition was lost in merge)
- Restore moe_mlp_glu_interleave_size field used by megatron/core/transformer/
  moe/experts.py
- Restore moe_hybridep_num_sms_preprocessing field
- Update InferenceTopKRouter.forward signature to accept input_ids and
  forward it to TopKRouter.forward, matching the new caller signature in
  moe_layer.py:446 (apply_module(self.router)(hidden_states, padding_mask,
  input_ids)). Without this, tests/unit_tests/inference/test_hybrid_moe.py::
  TestDynamicInferenceNVLS fails with TypeError: forward() takes from 2 to
  3 positional arguments but 4 were given.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Phlip79
Phlip79 force-pushed the main2dev/05_05_2026 branch from 3567666 to 9a0cbdd Compare May 5, 2026 16:59
@Phlip79

Phlip79 commented May 5, 2026

Copy link
Copy Markdown
Member

/ok to test 9a0cbdd

@Phlip79

Phlip79 commented May 5, 2026

Copy link
Copy Markdown
Member

/ok to test 9a0cbdd

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor Author

Superseded by today's nightly sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Run functional tests Run MBridge tests Attach this for testing this PR against MBridge main

Projects

None yet

Development

Successfully merging this pull request may close these issues.