feat(ckpt): expose validate_access_integrity knob on dist-ckpt load - #4422
Merged
Conversation
The training load path in `_load_global_dist_base_checkpoint` invoked `dist_checkpointing.load(...)` without forwarding `validate_access_integrity`, effectively hardcoding it to the default `True`. The save path already exposes the equivalent toggle through `args.ckpt_assume_constant_structure`, so this restores symmetry. Add a new CheckpointConfig field `ckpt_load_validate_sharding_integrity` (default `True`, matching prior behavior) which the argument factory turns into `--no-ckpt-load-validate-sharding-integrity`, and forward it to `dist_checkpointing.load`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
asolergi-nv
marked this pull request as ready for review
April 22, 2026 13:14
deepakn94
approved these changes
Apr 22, 2026
maanug-nv
approved these changes
Apr 24, 2026
Contributor
Author
|
/ok to test 81b024b |
Contributor
Author
|
/ok to test 6afe4d9 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24912906725 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24914629181 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24916866735 |
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
…VIDIA#4422) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
yhgalaxy
pushed a commit
to yhgalaxy/Megatron-LM
that referenced
this pull request
Jun 17, 2026
…VIDIA#4422) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker
pushed a commit
to jon-barker/Megatron-LM
that referenced
this pull request
Jul 10, 2026
…VIDIA#4422) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
…VIDIA#4422) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Expose
validate_access_integrityon the distributed-checkpoint load path via a new--no-ckpt-load-validate-sharding-integrityCLI flag, so users can opt out of the shard access integrity check when loading. Default preserves the previous hardcoded behavior (True).Details
megatron/training/checkpointing.py::_load_global_dist_base_checkpointpreviously calleddist_checkpointing.load(...)without forwardingvalidate_access_integrity, effectively hardcoding it to theserialization.pydefault (True). The save path already exposes the equivalent toggle viaargs.ckpt_assume_constant_structure(validate_sharding_integrity), so this restores symmetry between save and load.CheckpointConfig.ckpt_load_validate_sharding_integrity: bool = True. The existingArgumentGroupFactoryauto-generates--no-ckpt-load-validate-sharding-integrity/--disable-ckpt-load-validate-sharding-integrityfor a bool field defaulting toTrue, which is the intended opt-out UX.dist_checkpointing.load(...).No behavior change with default flags.
Contribution process
Pre-checks