Skip to content

Checkpoint conversion between GPT_model and Hybrid_model - #4482

Merged
guihong-nv merged 14 commits into
NVIDIA:mainfrom
guihong-nv:convert_ckpt
May 4, 2026
Merged

Checkpoint conversion between GPT_model and Hybrid_model#4482
guihong-nv merged 14 commits into
NVIDIA:mainfrom
guihong-nv:convert_ckpt

Conversation

@guihong-nv

@guihong-nv guihong-nv commented Apr 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do ?

  • Checkpoint conversion between GPT_model and Hybrid_model
  • For GPT_model, we do not support the legacy models

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@guihong-nv
Add the support for checkpoint conversion between GPT_model and Hybri…
0e7f400 
…d_model

Signed-off-by: guihong-nv <guihongl@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Apr 27, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@guihong-nv
Remove the support for GPT legacy model
fef2eb0 
Signed-off-by: guihong-nv <guihongl@nvidia.com>
@guihong-nv
Auto-format the code
366d5f8 
Signed-off-by: guihong-nv <guihongl@nvidia.com>
@guihong-nv
Add the EP support and test cases
cfe4969 
Signed-off-by: guihong-nv <guihongl@nvidia.com>
@guihong-nv
Auto format the code
c0a9682 
Signed-off-by: guihong-nv <guihongl@nvidia.com>
@guihong-nv
Add missing copyright header
6278662 
Signed-off-by: guihong-nv <guihongl@nvidia.com>
@guihong-nv
Add the multi-node unit test bypass logic
763bdb6 
Signed-off-by: guihong-nv <guihongl@nvidia.com>
@guihong-nv
Format the code to meet the linting requirement
2f9c46d 
Signed-off-by: guihong-nv <guihongl@nvidia.com>
@guihong-nv

guihong-nv commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 2f9c46d

@guihong-nv
guihong-nv marked this pull request as ready for review April 30, 2026 15:55
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team April 30, 2026 15:55
@ericharper
ericharper added this pull request to the merge queue Apr 30, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25177806849

@Phlip79
Phlip79 removed this pull request from the merge queue due to a manual request Apr 30, 2026
Phlip79
Phlip79 requested changes Apr 30, 2026
View reviewed changes

@Phlip79 Phlip79 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update references from MambaModel to HybridModel (and all other references to Mamba)? Mamba should only be a reference to the layer (i.e. SSM).

@guihong-nv
Rename mamba_model into hybrid_model
e2e6357
@guihong-nv
Fix linting issues
e532385 
Signed-off-by: guihong-nv <guihongl@nvidia.com>
@guihong-nv

guihong-nv commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test e532385

@guihong-nv
guihong-nv enabled auto-merge April 30, 2026 22:48
@guihong-nv

guihong-nv commented May 1, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 70be8b1

@guihong-nv
guihong-nv requested a review from Phlip79 May 1, 2026 18:55
@guihong-nv

guihong-nv commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test d46f82a

@guihong-nv
guihong-nv added this pull request to the merge queue May 4, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented May 4, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25332718061

Merged via the queue into NVIDIA:main with commit cf21d70 May 4, 2026
65 of 68 checks passed
@guihong-nv
guihong-nv deleted the convert_ckpt branch May 4, 2026 19:34
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
@guihong-nv @yhgalaxy
Checkpoint conversion between GPT_model and Hybrid_model (NVIDIA#4482)
954013e 
Signed-off-by: guihong-nv <guihongl@nvidia.com>
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
mathemakitten pushed a commit to mathemakitten/Megatron-LM that referenced this pull request Jul 1, 2026
@guihong-nv @mathemakitten
Checkpoint conversion between GPT_model and Hybrid_model (NVIDIA#4482)
60c5664 
Signed-off-by: guihong-nv <guihongl@nvidia.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
@guihong-nv Jon Barker
Checkpoint conversion between GPT_model and Hybrid_model (NVIDIA#4482)
3efb265 
Signed-off-by: guihong-nv <guihongl@nvidia.com>
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
@guihong-nv @terminator123
Checkpoint conversion between GPT_model and Hybrid_model (NVIDIA#4482)
8b41a7b 
Signed-off-by: guihong-nv <guihongl@nvidia.com>
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
@guihong-nv @dimapihtar
Checkpoint conversion between GPT_model and Hybrid_model (NVIDIA#4482)
bc613ab 
Signed-off-by: guihong-nv <guihongl@nvidia.com>
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Phlip79 Phlip79 Phlip79 approved these changes
@dimapihtar dimapihtar dimapihtar approved these changes

Assignees

No one assigned

Labels

complexity: high

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guihong-nv @svcnvidia-nemo-ci @Phlip79 @dimapihtar