Misc inference fixes - #4397
Conversation
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
|
||
|
|
||
| @triton.jit | ||
| def fast_exp(x): |
There was a problem hiding this comment.
I have seen this trick before but does this change numerics at all, as in is accuracy of models training without it giving the same accuracy? also assuming this is used for both training and inference so we dont get larger train/inference diff
There was a problem hiding this comment.
I am not sure if these kernels are used in training. I do not see a backwards pass here, so I assume they are not.
Concerns about numerics are valid. This trick is borrowed from vLLM, so atleast it has some precedent.
There was a problem hiding this comment.
Can we verify that our functional tests still pass at least?
… ignore_eos" This reverts commit d5c5001.
cd5dde2 to
b199aa1
Compare
|
|
||
|
|
||
| @triton.jit | ||
| def fast_exp(x): |
There was a problem hiding this comment.
Can we verify that our functional tests still pass at least?
santhnm2
left a comment
There was a problem hiding this comment.
LGTM assuming functional tests pass (i.e., no meaningful difference in numerics as a result of the fast_exp change)
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24816508234 |
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
What does this PR do ?
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.