Skip to content

Misc inference fixes - #4397

Merged
sidsingh-nvidia merged 16 commits into
NVIDIA:mainfrom
sidsingh-nvidia:siddharth/misc-inference-fixes
Apr 23, 2026
Merged

Misc inference fixes#4397
sidsingh-nvidia merged 16 commits into
NVIDIA:mainfrom
sidsingh-nvidia:siddharth/misc-inference-fixes

Conversation

@sidsingh-nvidia

Copy link
Copy Markdown
Contributor

What does this PR do ?

  1. Tune ssm inference update kernel for blackwell machines - fewer blocks, with larger number of warps. This is applicable to nemotron models.
  2. Fix the completions API to return usage statistics and accept ignore_eos.
  3. Initialize sq_relu output buffers with torch.empty

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@sidsingh-nvidia
sidsingh-nvidia requested review from a team as code owners April 20, 2026 19:41
@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft April 20, 2026 19:41
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Apr 20, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Apr 20, 2026


@triton.jit
def fast_exp(x):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen this trick before but does this change numerics at all, as in is accuracy of models training without it giving the same accuracy? also assuming this is used for both training and inference so we dont get larger train/inference diff

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if these kernels are used in training. I do not see a backwards pass here, so I assume they are not.

Concerns about numerics are valid. This trick is borrowed from vLLM, so atleast it has some precedent.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we verify that our functional tests still pass at least?

@sidsingh-nvidia
sidsingh-nvidia force-pushed the siddharth/misc-inference-fixes branch from cd5dde2 to b199aa1 Compare April 20, 2026 19:50


@triton.jit
def fast_exp(x):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we verify that our functional tests still pass at least?

@sidsingh-nvidia
sidsingh-nvidia marked this pull request as ready for review April 21, 2026 06:13
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team April 21, 2026 06:14
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Final Review PR is in the "final review" stage complexity: low labels Apr 21, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci removed the Final Review PR is in the "final review" stage label Apr 22, 2026

@santhnm2 santhnm2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming functional tests pass (i.e., no meaningful difference in numerics as a result of the fast_exp change)

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Apr 22, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Apr 22, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24816508234

Merged via the queue into NVIDIA:main with commit ab2b33d Apr 23, 2026
186 checks passed
@sidsingh-nvidia
sidsingh-nvidia deleted the siddharth/misc-inference-fixes branch April 23, 2026 06:02
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants