feat: supports evaluation of multiple-choice benchmarks#559
Merged
parthchadha merged 46 commits intoNVIDIA-NeMo:mainfrom Jul 3, 2025
Merged
feat: supports evaluation of multiple-choice benchmarks#559parthchadha merged 46 commits intoNVIDIA-NeMo:mainfrom
parthchadha merged 46 commits intoNVIDIA-NeMo:mainfrom
Conversation
yuki-97
reviewed
Jun 27, 2025
Contributor
yuki-97
left a comment
There was a problem hiding this comment.
Awesome! Thanks for contributing, overall LGTM. Left some comments.
xxman-google
commented
Jun 27, 2025
Contributor
Author
xxman-google
left a comment
There was a problem hiding this comment.
Thanks for the review. All comments are addressed. PTAL agian.
Contributor
|
Thanks @xxman-google , all changes LGTM! Could you also update the doc? |
Contributor
|
Also, your PR appears to have a DCO error. It looks like this commit 42155d9 not signed. |
57ccd9b to
dbf4800
Compare
Contributor
Author
|
Thanks @YUki-666 . Docs are updated and DCO erro is also fixed. |
Contributor
|
@xxman-google Seems there is a conflict? Could you try merge main again to see if the conflict could be solved? |
Signed-off-by: Xuehan Xiong <xxman@google.com> Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: Xuehan Xiong <xxman@google.com> Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: Xuehan Xiong <xxman@google.com> Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: Xuehan Xiong <xxman@google.com> Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: Xuehan Xiong <xxman@google.com> Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: Xuehan Xiong xxman@google.com Signed-off-by: Xuehan Xiong <xxman@google.com> Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: Xuehan Xiong <xxman@google.com> Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: Xuehan Xiong xxman@google.com Signed-off-by: Xuehan Xiong <xxman@google.com> Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: Xuehan <xxman@google.com>
…IA-NeMo#565) Signed-off-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: Parth Chadha <pchadha@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Signed-off-by: Xuehan <xxman@google.com>
…eMo#494) Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: Xuehan Xiong xxman@google.com Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: Xuehan Xiong <xxman@google.com> Signed-off-by: Xuehan <xxman@google.com>
…IDIA-NeMo#516) Signed-off-by: Luis Vega <vegaluisjose@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Luis Vega <2478335+vegaluisjose@users.noreply.github.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Luis Vega <2478335+vegaluisjose@users.noreply.github.com> Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: Parth Chadha <pchadha@nvidia.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: Xuehan <xxman@google.com>
…NeMo#570) Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: Xuehan <xxman@google.com>
…req (NVIDIA-NeMo#574) Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: Xuehan <xxman@google.com>
parthchadha
reviewed
Jul 2, 2025
Signed-off-by: Xuehan Xiong <xxman@google.com>
auto-merge was automatically disabled
July 2, 2025 19:57
Head branch was pushed to by a user without write access
Signed-off-by: Shun Kiyono <shun.kiyono@sbintuitions.co.jp>
…-NeMo#583) Signed-off-by: Wei Du <wedu@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Sahil Jain <sahilj@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
Signed-off-by: Atsunori Fujita <afujita@nvidia.com>
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: Anna Shors <ashors@nvidia.com> Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: Xuehan <xxman@google.com>
Signed-off-by: Xuehan <xxman@google.com>
parthchadha
approved these changes
Jul 2, 2025
therealnaveenkamal
pushed a commit
to therealnaveenkamal/RL
that referenced
this pull request
Jul 7, 2025
) Signed-off-by: Xuehan Xiong <xxman@google.com> Signed-off-by: Xuehan <xxman@google.com> Signed-off-by: Xuehan Xiong xxman@google.com Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Signed-off-by: Luis Vega <vegaluisjose@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Luis Vega <2478335+vegaluisjose@users.noreply.github.com> Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Anna Shors <ashors@nvidia.com> Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com> Signed-off-by: Sahil Jain <sahilj@nvidia.com> Signed-off-by: Yuki Huang <scsse_hqh2016@126.com> Signed-off-by: Shun Kiyono <shun.kiyono@sbintuitions.co.jp> Signed-off-by: Wei Du <wedu@nvidia.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Atsunori Fujita <afujita@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com> Co-authored-by: Zhaocheng Zhu <zhaochengz@nvidia.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Luis Vega <vegaluisjose@users.noreply.github.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Luis Vega <2478335+vegaluisjose@users.noreply.github.com> Co-authored-by: Yi-Fu Wu <yifu.wu@gmail.com> Co-authored-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Dheeraj Peri <peri.dheeraj@gmail.com> Co-authored-by: Yuki Huang <scsse_hqh2016@126.com> Co-authored-by: Shun Kiyono <shunk52@gmail.com> Co-authored-by: Wei Du <wedu@nvidia.com> Co-authored-by: Charlie Truong <chtruong@nvidia.com> Co-authored-by: atfujita <40932835+AtsunoriFujita@users.noreply.github.com>
YzjiaoNvd
pushed a commit
to YzjiaoNvd/NeMo-RL
that referenced
this pull request
Jul 14, 2025
) Signed-off-by: Xuehan Xiong <xxman@google.com> Signed-off-by: Xuehan <xxman@google.com> Signed-off-by: Xuehan Xiong xxman@google.com Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Signed-off-by: Luis Vega <vegaluisjose@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Luis Vega <2478335+vegaluisjose@users.noreply.github.com> Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Anna Shors <ashors@nvidia.com> Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com> Signed-off-by: Sahil Jain <sahilj@nvidia.com> Signed-off-by: Yuki Huang <scsse_hqh2016@126.com> Signed-off-by: Shun Kiyono <shun.kiyono@sbintuitions.co.jp> Signed-off-by: Wei Du <wedu@nvidia.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Atsunori Fujita <afujita@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com> Co-authored-by: Zhaocheng Zhu <zhaochengz@nvidia.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Luis Vega <vegaluisjose@users.noreply.github.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Luis Vega <2478335+vegaluisjose@users.noreply.github.com> Co-authored-by: Yi-Fu Wu <yifu.wu@gmail.com> Co-authored-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Dheeraj Peri <peri.dheeraj@gmail.com> Co-authored-by: Yuki Huang <scsse_hqh2016@126.com> Co-authored-by: Shun Kiyono <shunk52@gmail.com> Co-authored-by: Wei Du <wedu@nvidia.com> Co-authored-by: Charlie Truong <chtruong@nvidia.com> Co-authored-by: atfujita <40932835+AtsunoriFujita@users.noreply.github.com>
jialei777
pushed a commit
to jialei777/nemo-rl
that referenced
this pull request
Jul 23, 2025
) Signed-off-by: Xuehan Xiong <xxman@google.com> Signed-off-by: Xuehan <xxman@google.com> Signed-off-by: Xuehan Xiong xxman@google.com Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Signed-off-by: Luis Vega <vegaluisjose@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Luis Vega <2478335+vegaluisjose@users.noreply.github.com> Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Anna Shors <ashors@nvidia.com> Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com> Signed-off-by: Sahil Jain <sahilj@nvidia.com> Signed-off-by: Yuki Huang <scsse_hqh2016@126.com> Signed-off-by: Shun Kiyono <shun.kiyono@sbintuitions.co.jp> Signed-off-by: Wei Du <wedu@nvidia.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Atsunori Fujita <afujita@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com> Co-authored-by: Zhaocheng Zhu <zhaochengz@nvidia.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Luis Vega <vegaluisjose@users.noreply.github.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Luis Vega <2478335+vegaluisjose@users.noreply.github.com> Co-authored-by: Yi-Fu Wu <yifu.wu@gmail.com> Co-authored-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Dheeraj Peri <peri.dheeraj@gmail.com> Co-authored-by: Yuki Huang <scsse_hqh2016@126.com> Co-authored-by: Shun Kiyono <shunk52@gmail.com> Co-authored-by: Wei Du <wedu@nvidia.com> Co-authored-by: Charlie Truong <chtruong@nvidia.com> Co-authored-by: atfujita <40932835+AtsunoriFujita@users.noreply.github.com> Signed-off-by: Jialei Chen <jialeic@google.com>
KiddoZhu
added a commit
that referenced
this pull request
Jul 28, 2025
Signed-off-by: Xuehan Xiong <xxman@google.com> Signed-off-by: Xuehan <xxman@google.com> Signed-off-by: Xuehan Xiong xxman@google.com Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Signed-off-by: Luis Vega <vegaluisjose@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Luis Vega <2478335+vegaluisjose@users.noreply.github.com> Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Anna Shors <ashors@nvidia.com> Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com> Signed-off-by: Sahil Jain <sahilj@nvidia.com> Signed-off-by: Yuki Huang <scsse_hqh2016@126.com> Signed-off-by: Shun Kiyono <shun.kiyono@sbintuitions.co.jp> Signed-off-by: Wei Du <wedu@nvidia.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Atsunori Fujita <afujita@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com> Co-authored-by: Zhaocheng Zhu <zhaochengz@nvidia.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Luis Vega <vegaluisjose@users.noreply.github.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Luis Vega <2478335+vegaluisjose@users.noreply.github.com> Co-authored-by: Yi-Fu Wu <yifu.wu@gmail.com> Co-authored-by: Anna Shors <ashors@nvidia.com> Co-authored-by: Dheeraj Peri <peri.dheeraj@gmail.com> Co-authored-by: Yuki Huang <scsse_hqh2016@126.com> Co-authored-by: Shun Kiyono <shunk52@gmail.com> Co-authored-by: Wei Du <wedu@nvidia.com> Co-authored-by: Charlie Truong <chtruong@nvidia.com> Co-authored-by: atfujita <40932835+AtsunoriFujita@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Supports evaluation of multiple-choice benchmarks, such as GPQA/MMLU/etc.
Issues
N/A
Usage
On GPQA, Qwen2.5-7B model scores 32.0 on average over 3 runs.
Before your PR is "Ready for review"
Pre checks:
Additional Information