docs: Add missing arguments to DeepScaler evaluation#502
Merged
SahilJain314 merged 2 commits intoNVIDIA-NeMo:mainfrom Jun 30, 2025
Merged
docs: Add missing arguments to DeepScaler evaluation#502SahilJain314 merged 2 commits intoNVIDIA-NeMo:mainfrom
SahilJain314 merged 2 commits intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: Shun Kiyono <shun.kiyono@sbintuitions.co.jp>
Contributor
|
Thanks for the PR! Slipped past us for a bit. |
abukharin-nv
previously approved these changes
Jun 27, 2025
Contributor
abukharin-nv
left a comment
There was a problem hiding this comment.
LGTM! I would also suggest increasing max_len to 32K, but that is kind of a subjective choice.
Contributor
Author
|
@abukharin-nv --> I am updating my PR. Please let me know if there's anything I can improve. |
Signed-off-by: Shun Kiyono <shun.kiyono@sbintuitions.co.jp>
3e00e33 to
d1564af
Compare
SahilJain314
approved these changes
Jun 30, 2025
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jun 30, 2025
Signed-off-by: Shun Kiyono <shun.kiyono@sbintuitions.co.jp>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jul 2, 2025
Signed-off-by: Shun Kiyono <shun.kiyono@sbintuitions.co.jp>
therealnaveenkamal
pushed a commit
to therealnaveenkamal/RL
that referenced
this pull request
Jul 7, 2025
Signed-off-by: Shun Kiyono <shun.kiyono@sbintuitions.co.jp>
YzjiaoNvd
pushed a commit
to YzjiaoNvd/NeMo-RL
that referenced
this pull request
Jul 14, 2025
Signed-off-by: Shun Kiyono <shun.kiyono@sbintuitions.co.jp>
KiddoZhu
pushed a commit
that referenced
this pull request
Jul 28, 2025
Signed-off-by: Shun Kiyono <shun.kiyono@sbintuitions.co.jp>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Shun Kiyono <shun.kiyono@sbintuitions.co.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR attempts to fix the document for deepscaler experiments
Currently, necessary arguments are missing, which leads to poor evaluation results
By specifying
cot.txt(as is done in training setup), the result improves a bit.By allowing the generation of more than 2048 tokens, the result is even better (This PR)
Issues
n/a
Usage
n/a
Before your PR is "Ready for review"
Pre checks: