Skip to content

fix: add dynamic_batching key to SFT OpenMathInstruct config#570

Merged
terrykong merged 1 commit intomainfrom
ashors/add-missing-key
Jun 27, 2025
Merged

fix: add dynamic_batching key to SFT OpenMathInstruct config#570
terrykong merged 1 commit intomainfrom
ashors/add-missing-key

Conversation

@ashors1
Copy link
Contributor

@ashors1 ashors1 commented Jun 27, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 marked this pull request as ready for review June 27, 2025 00:24
@ashors1 ashors1 requested review from terrykong and yfw June 27, 2025 00:24
@terrykong terrykong added this pull request to the merge queue Jun 27, 2025
Merged via the queue into main with commit 3c62910 Jun 27, 2025
13 of 14 checks passed
@terrykong terrykong deleted the ashors/add-missing-key branch June 27, 2025 20:14
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jun 27, 2025
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jun 30, 2025
…NeMo#570)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Xuehan <xxman@google.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jun 30, 2025
…NeMo#570)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Xuehan <xxman@google.com>
therealnaveenkamal pushed a commit to therealnaveenkamal/RL that referenced this pull request Jul 7, 2025
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jul 14, 2025
KiddoZhu pushed a commit that referenced this pull request Jul 28, 2025
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants