fix: prevent divisible error by dropping last batch in loader#583
Merged
SahilJain314 merged 1 commit intoNVIDIA-NeMo:mainfrom Jun 30, 2025
Merged
Conversation
parthchadha
approved these changes
Jun 30, 2025
SahilJain314
approved these changes
Jun 30, 2025
Signed-off-by: Wei Du <wedu@nvidia.com>
0cf209a to
9f8bef4
Compare
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jul 2, 2025
…-NeMo#583) Signed-off-by: Wei Du <wedu@nvidia.com>
therealnaveenkamal
pushed a commit
to therealnaveenkamal/RL
that referenced
this pull request
Jul 7, 2025
…-NeMo#583) Signed-off-by: Wei Du <wedu@nvidia.com>
YzjiaoNvd
pushed a commit
to YzjiaoNvd/NeMo-RL
that referenced
this pull request
Jul 14, 2025
…-NeMo#583) Signed-off-by: Wei Du <wedu@nvidia.com>
KiddoZhu
pushed a commit
that referenced
this pull request
Jul 28, 2025
Signed-off-by: Wei Du <wedu@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
add
drop_last=Trueto prevent divisible error by dropping last batch in loader
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information