Merged
Conversation
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
terrykong
approved these changes
Jun 27, 2025
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jun 28, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jun 30, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jun 30, 2025
Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: Xuehan <xxman@google.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jun 30, 2025
Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: Xuehan <xxman@google.com>
therealnaveenkamal
pushed a commit
to therealnaveenkamal/RL
that referenced
this pull request
Jul 7, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
YzjiaoNvd
pushed a commit
to YzjiaoNvd/NeMo-RL
that referenced
this pull request
Jul 14, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
KiddoZhu
pushed a commit
that referenced
this pull request
Jul 28, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
When using overlap param gather, Mcore does a single param all-gather after each backward pass (before the first forward step). This is problematic when the first forward pass following a backward pass is using the reference model parameters, because we end up doing an all-gather on the reference parameters rather than the model being trained. The solution is to disable overlap param gather when running reference model forward and re-enable after.
Issues
Closes #552
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information