add build script for intel oneapi and gcc compiler separately by xyuan · Pull Request #88 · NOAA-GFDL/pace

xyuan · 2024-06-17T15:19:44Z

Description
add build env script for intel oneAPI build and gcc build of Pace with optimization options for loop unroll, and array prefetch.

please note that these options are needed to be incorported in the regression test and container build, with the purpose of supporting various supercomputers in the future.

Fixes # (issue)
If this is a hotfix to a released version, please specify it.

How Has This Been Tested?
The options for Intel compiler are tested using
Intel(R) oneAPI DPC++/C++ Compiler for applications running on Intel(R) 64, Version 2024.1.0 Build 20240308

and the gcc compiler was tesed using
gcc 13.2

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules
New check tests, if applicable, are included

fmalatino · 2024-06-17T15:24:02Z

A couple of questions:

Do we want to continue to suport python 3.8?

Should we allow the user to pass the desired name for the conda environment to be used, or do we want to keep it as my_name in general?

nope, let me test python 3.11.9, and update the script

fmalatino

lgtm

FlorianDeconinck · 2024-06-17T16:17:36Z

This requires a new GT4Py

fmalatino · 2024-06-17T16:21:35Z

This requires a new GT4Py

@xyuan Does this PR depend on your PR 1552 in GT4Py?

xyuan · 2024-06-17T17:07:13Z

This requires a new GT4Py

@xyuan Does this PR depend on your PR 1552 in GT4Py?

yes, but it is still safe to merge it to pace

oelbert

Small q about the python module import on C5, otherwise LGTM

oelbert · 2024-06-18T15:10:33Z

+module rm gcc
+module load gcc/12.2.0
+module load boost/1.79.0
+module load python/3.9


Should we update the python version here too?

yes, updated to the python 3.11.7

fmalatino

Approved pending changes to examples/build_scripts/build_gaea_c5_gcc.sh to update python version to 3.11

…n for gcc

fmalatino

lgtm

oelbert

Assuming the gt4py version is ok we're 👍

* working baroclinic test case example (#81) * fixing dockerfile overriding netcdf, mpi4py, and numpy versions with mutually incompatible versions (#84) * Update notebooks for eta file creations (#85) * updated generate_eta_files * remove notebook, add script * lint --------- Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov> * Update pace to use python 3.11.9 (#82) * Updates to allow use of python3.11 * Removed main_unit_tests.yml as it is covered by tests in containers * Updated images for unit tests with openmpi and mpich * Updated container for Github Action and reusable workflow (#87) * updated generate_eta_files * remove notebook, add script * lint * correct path * update constraints * python3 execute * Update main_unit_tests_mpich.yaml * Update main_unit_tests_mpich.yaml * update input directory * get ..s correct * lint --------- Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov> * Updated container for Github Action and reusable workflow - Redo (#89) * test * tet * fix test dir * test * checkout pace * rename * test * rm * remove dir * fix name * test * pyshield * test * fix trigger mistake * test * change lint version * remove push * lint --------- Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov> * Matching packages between main and develop branches and removal of outdated pull request template (#86) * Changed workflows to use python 3.11.7, added pytest-subtests to requirments_dev.txt * Matched package dependencies between main and develop branches * Updating constraints file * Updating Dockerfile to use 3.11-slim-bookworm base python image * reusable workflow CI - checkout corrrect repository (#90) * fix trigger mistake * fix spacking * update yaml files * rename lint.yaml * remove backup yaml file * simply pull request trigger * beloved lint --------- Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov> * add build script for intel oneapi and gcc compiler separately (#88) * add build script for intel oneapi and gcc compiler separately * update the python version and remove the link time optimization option for gcc * pace/tests/main/grid/test_eta.py moved to NDSL/tests/grid/test_eta.py (#92) * Removed test_eta.py, moved to NDSL/tests/grid * Updated constraints to reflect incoming new versions of subrepositories (#94) * Updated README to include directions for generating eta files (#99) * Updated README to include directions for generating eta files * Linting * Updated baroclinic_c2.yaml to generate zarr output * Update submodules and addition of baroclinic run to workflow (#101) * Updated submodules as of 21 Jan 2025, and added baroclinic run to github workflow * Hotfix/update netcdf version for docker files (#102) * Update netcdf version * also upgrade pip * update ndsl * `xarray` to `2025.01.2` to grab the `DataTree` (#103) * Update submodules (#104) * Updated submodules to versions as of 15 Jan 2025 * Updated submodules as of 21 Jan 2025, and added baroclinic run to github workflow * Updated submodules as of 5 09:49 March 2025 * Reverting changes to build_gaea_c5_gcc.sh * Reverting changes to build_gaea_c5_gcc.sh one more thing --------- Co-authored-by: Oliver Elbert <oliver.elbert36@gmail.com> Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com> Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov> Co-authored-by: Xingqiu Yuan <xingqiu.yuan@noaa.gov> Co-authored-by: Florian Deconinck <deconinck.florian@gmail.com>

…NOAA-GFDL#64

… PyFV3 PR #88] (#152) * Tmp dycore dacite config related to PyFV3 PR #88 + NDSL Issue #64 * test_config.py tweak for type checks --------- Co-authored-by: Florian Deconinck <deconinck.florian@gmail.com>

Clean up after pyFV3 PR NOAA-GFDL#88

…153) * Tmp physics dacite config related to NDSL Issue #64 Clean up after pyFV3 PR #88 * Updating pyFV3 submodule * Updating pyFV3 submodule after PyFV3 PR #90

add build script for intel oneapi and gcc compiler separately

5eea59b

xyuan requested review from FlorianDeconinck, bensonr and fmalatino June 17, 2024 15:20

fmalatino requested review from mlee03 and oelbert June 17, 2024 15:21

fmalatino reviewed Jun 17, 2024

View reviewed changes

using python 3.11.9

2e234c9

fmalatino approved these changes Jun 17, 2024

View reviewed changes

oelbert reviewed Jun 18, 2024

View reviewed changes

fmalatino requested changes Jul 1, 2024

View reviewed changes

update the python version and remove the link time optimization optio…

8eb0c9e

…n for gcc

fmalatino approved these changes Jul 9, 2024

View reviewed changes

fmalatino requested a review from oelbert July 9, 2024 18:51

oelbert approved these changes Jul 10, 2024

View reviewed changes

fmalatino merged commit 4e2521d into develop Jul 10, 2024

xyuan deleted the xyuan/compiler branch July 16, 2024 19:48

jjuyeonkim added a commit to jjuyeonkim/pace that referenced this pull request Oct 15, 2025

Tmp dycore dacite config related to PyFV3 PR NOAA-GFDL#88 + NDSL Issue …

f52cefe

…NOAA-GFDL#64

jjuyeonkim added a commit to jjuyeonkim/pace that referenced this pull request Oct 21, 2025

Tmp physics dacite config related to NDSL Issue NOAA-GFDL#64

9a25be6

Clean up after pyFV3 PR NOAA-GFDL#88

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add build script for intel oneapi and gcc compiler separately#88

add build script for intel oneapi and gcc compiler separately#88
fmalatino merged 3 commits into
developfrom
xyuan/compiler

xyuan commented Jun 17, 2024

Uh oh!

fmalatino Jun 17, 2024 •

edited

Loading

Uh oh!

xyuan Jun 17, 2024

Uh oh!

fmalatino left a comment

Uh oh!

FlorianDeconinck commented Jun 17, 2024

Uh oh!

fmalatino commented Jun 17, 2024

Uh oh!

xyuan commented Jun 17, 2024

Uh oh!

oelbert left a comment

Uh oh!

oelbert Jun 18, 2024

Uh oh!

xyuan Jul 9, 2024

Uh oh!

fmalatino left a comment

Uh oh!

fmalatino left a comment

Uh oh!

oelbert left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

xyuan commented Jun 17, 2024

Uh oh!

fmalatino Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xyuan Jun 17, 2024

Choose a reason for hiding this comment

Uh oh!

fmalatino left a comment

Choose a reason for hiding this comment

Uh oh!

FlorianDeconinck commented Jun 17, 2024

Uh oh!

fmalatino commented Jun 17, 2024

Uh oh!

xyuan commented Jun 17, 2024

Uh oh!

oelbert left a comment

Choose a reason for hiding this comment

Uh oh!

oelbert Jun 18, 2024

Choose a reason for hiding this comment

Uh oh!

xyuan Jul 9, 2024

Choose a reason for hiding this comment

Uh oh!

fmalatino left a comment

Choose a reason for hiding this comment

Uh oh!

fmalatino left a comment

Choose a reason for hiding this comment

Uh oh!

oelbert left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fmalatino Jun 17, 2024 •

edited

Loading