Skip to content

working baroclinic test case example#81

Merged
fmalatino merged 1 commit into
NOAA-GFDL:developfrom
oelbert:example/baroclinic_notebook
Apr 19, 2024
Merged

working baroclinic test case example#81
fmalatino merged 1 commit into
NOAA-GFDL:developfrom
oelbert:example/baroclinic_notebook

Conversation

@oelbert

@oelbert oelbert commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator

Description
Includes an example of the moist baroclinic instability test case and resolves a couple of final notebook version mismatches

How Has This Been Tested?
The example notebook has been run from scratch with a newly built image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

fmalatino
fmalatino approved these changes Apr 19, 2024
View reviewed changes

@fmalatino fmalatino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FlorianDeconinck

FlorianDeconinck commented Apr 19, 2024

Copy link
Copy Markdown
Collaborator

Great work. We really ought to have those notebooks parts of the ci, they are great woopsies catcher

@fmalatino fmalatino merged commit e535ba6 into NOAA-GFDL:develop Apr 19, 2024
@mlee03

mlee03 commented Apr 19, 2024

Copy link
Copy Markdown
Collaborator

Which notebooks should be considered part of CI? I can add them to run in the CI container.

@FlorianDeconinck

FlorianDeconinck commented Apr 19, 2024

Copy link
Copy Markdown
Collaborator

I'd say all? Unless they take a large amount of time, but since they are example of usage they should all be checked to be working

@mlee03

mlee03 commented Apr 19, 2024

Copy link
Copy Markdown
Collaborator

Will look into it!

@oelbert

oelbert commented Apr 19, 2024

Copy link
Copy Markdown
Collaborator Author

I think the baroclinic_example, geberate_eta_file, and stencil_definition notebooks are the most important ones

fmalatino added a commit that referenced this pull request Jan 6, 2025
@fmalatino @oelbert @mlee03
Update Benchmark branch to use NDSL v2024.09.00 (#96)
c64fa64 
* working baroclinic test case example (#81)

* fixing dockerfile overriding netcdf, mpi4py, and numpy versions with mutually incompatible versions (#84)

* Update notebooks for eta file creations  (#85)

* Update pace to use python 3.11.9 (#82)

* Updated container for Github Action and reusable workflow (#87)

* Updated container for Github Action and reusable workflow - Redo (#89)

* Matching packages between main and develop branches and removal of outdated pull request template (#86)

* Changed workflows to use python 3.11.7, added pytest-subtests to requirments_dev.txt

* Updating constraints file

* Updating Dockerfile to use 3.11-slim-bookworm base python image

* reusable workflow CI - checkout corrrect repository (#90)

* pace/tests/main/grid/test_eta.py moved to NDSL/tests/grid/test_eta.py (#92)

* Updated README to include directions for generating eta files (#99)

* Updated submodules to most recent versions as of 3 Jan 2025 15:35 EST

* Updated c5 build script to match new methods

---------

Co-authored-by: Oliver Elbert <oliver.elbert36@gmail.com>
Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com>
Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>
Co-authored-by: Xingqiu Yuan <xingqiu.yuan@noaa.gov>
fmalatino added a commit that referenced this pull request Mar 11, 2025
@fmalatino @oelbert
@mlee03 @FlorianDeconinck
Update submodules of benchmark (#107)
68c6fdd 
* working baroclinic test case example (#81)

* fixing dockerfile overriding netcdf, mpi4py, and numpy versions with mutually incompatible versions (#84)

* Update notebooks for eta file creations  (#85)

* updated generate_eta_files

* remove notebook, add script

* lint

---------

Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>

* Update pace to use python 3.11.9 (#82)

* Updates to allow use of python3.11

* Removed main_unit_tests.yml as it is covered by tests in containers

* Updated images for unit tests with openmpi and mpich

* Updated container for Github Action and reusable workflow (#87)

* updated generate_eta_files

* remove notebook, add script

* lint

* correct path

* update constraints

* python3 execute

* Update main_unit_tests_mpich.yaml

* Update main_unit_tests_mpich.yaml

* update input directory

* get ..s correct

* lint

---------

Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>

* Updated container for Github Action and reusable workflow - Redo (#89)

* test

* tet

* fix test dir

* test

* checkout pace

* rename

* test

* rm

* remove dir

* fix name

* test

* pyshield

* test

* fix trigger mistake

* test

* change lint version

* remove push

* lint

---------

Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>

* Matching packages between main and develop branches and removal of outdated pull request template (#86)

* Changed workflows to use python 3.11.7, added pytest-subtests to requirments_dev.txt

* Matched package dependencies between main and develop branches

* Updating constraints file

* Updating Dockerfile to use 3.11-slim-bookworm base python image

* reusable workflow CI - checkout corrrect repository (#90)

* fix trigger mistake

* fix spacking

* update yaml files

* rename lint.yaml

* remove backup yaml file

* simply pull request trigger

* beloved lint

---------

Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>

* add build script for intel oneapi and gcc compiler separately (#88)

* add build script for intel oneapi and gcc compiler separately

* update the python version and remove the link time optimization option for gcc

* pace/tests/main/grid/test_eta.py moved to NDSL/tests/grid/test_eta.py (#92)

* Removed test_eta.py, moved to NDSL/tests/grid

* Updated constraints to reflect incoming new versions of subrepositories (#94)

* Updated README to include directions for generating eta files (#99)

* Updated README to include directions for generating eta files

* Linting

* Updated baroclinic_c2.yaml to generate zarr output

* Update submodules and addition of baroclinic run to workflow (#101)

* Updated submodules as of 21 Jan 2025, and added baroclinic run to github workflow

* Hotfix/update netcdf version for docker files (#102)

* Update netcdf version

* also upgrade pip

* update ndsl

* `xarray` to `2025.01.2` to grab the `DataTree` (#103)

* Update submodules (#104)

* Updated submodules to versions as of 15 Jan 2025

* Updated submodules as of 21 Jan 2025, and added baroclinic run to github workflow

* Updated submodules as of 5  09:49 March 2025

* Reverting changes to build_gaea_c5_gcc.sh

* Reverting changes to build_gaea_c5_gcc.sh one more thing

---------

Co-authored-by: Oliver Elbert <oliver.elbert36@gmail.com>
Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com>
Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>
Co-authored-by: Xingqiu Yuan <xingqiu.yuan@noaa.gov>
Co-authored-by: Florian Deconinck <deconinck.florian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FlorianDeconinck FlorianDeconinck FlorianDeconinck approved these changes

@fmalatino fmalatino fmalatino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oelbert @FlorianDeconinck @mlee03 @fmalatino