Skip to content

Hotfix/update netcdf version for docker files#102

Merged
fmalatino merged 4 commits into
NOAA-GFDL:developfrom
oelbert:develop
Jan 27, 2025
Merged

Hotfix/update netcdf version for docker files#102
fmalatino merged 4 commits into
NOAA-GFDL:developfrom
oelbert:develop

Conversation

@oelbert
Copy link
Copy Markdown
Collaborator

@oelbert oelbert commented Jan 22, 2025

Description
Updates the netcdf4 python version to 1.7.1 which fixes path errors that prevented the docker images from building successfully

How Has This Been Tested?
Docker images have been successfully rebuilt after this update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

fmalatino
fmalatino previously approved these changes Jan 22, 2025
@oelbert
Copy link
Copy Markdown
Collaborator Author

oelbert commented Jan 22, 2025

This PR and NDSL PR NOAA-GFDL/NDSL#100 both depend on each other to pass...

Copy link
Copy Markdown
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fmalatino fmalatino merged commit 5092938 into NOAA-GFDL:develop Jan 27, 2025
fmalatino added a commit that referenced this pull request Mar 11, 2025
* working baroclinic test case example (#81)

* fixing dockerfile overriding netcdf, mpi4py, and numpy versions with mutually incompatible versions (#84)

* Update notebooks for eta file creations  (#85)

* updated generate_eta_files

* remove notebook, add script

* lint

---------

Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>

* Update pace to use python 3.11.9 (#82)

* Updates to allow use of python3.11

* Removed main_unit_tests.yml as it is covered by tests in containers

* Updated images for unit tests with openmpi and mpich

* Updated container for Github Action and reusable workflow (#87)

* updated generate_eta_files

* remove notebook, add script

* lint

* correct path

* update constraints

* python3 execute

* Update main_unit_tests_mpich.yaml

* Update main_unit_tests_mpich.yaml

* update input directory

* get ..s correct

* lint

---------

Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>

* Updated container for Github Action and reusable workflow - Redo (#89)

* test

* tet

* fix test dir

* test

* checkout pace

* rename

* test

* rm

* remove dir

* fix name

* test

* pyshield

* test

* fix trigger mistake

* test

* change lint version

* remove push

* lint

---------

Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>

* Matching packages between main and develop branches and removal of outdated pull request template (#86)

* Changed workflows to use python 3.11.7, added pytest-subtests to requirments_dev.txt

* Matched package dependencies between main and develop branches

* Updating constraints file

* Updating Dockerfile to use 3.11-slim-bookworm base python image

* reusable workflow CI - checkout corrrect repository (#90)

* fix trigger mistake

* fix spacking

* update yaml files

* rename lint.yaml

* remove backup yaml file

* simply pull request trigger

* beloved lint

---------

Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>

* add build script for intel oneapi and gcc compiler separately (#88)

* add build script for intel oneapi and gcc compiler separately

* update the python version and remove the link time optimization option for gcc

* pace/tests/main/grid/test_eta.py moved to NDSL/tests/grid/test_eta.py (#92)

* Removed test_eta.py, moved to NDSL/tests/grid

* Updated constraints to reflect incoming new versions of subrepositories (#94)

* Updated README to include directions for generating eta files (#99)

* Updated README to include directions for generating eta files

* Linting

* Updated baroclinic_c2.yaml to generate zarr output

* Update submodules and addition of baroclinic run to workflow (#101)

* Updated submodules as of 21 Jan 2025, and added baroclinic run to github workflow

* Hotfix/update netcdf version for docker files (#102)

* Update netcdf version

* also upgrade pip

* update ndsl

* `xarray` to `2025.01.2` to grab the `DataTree` (#103)

* Update submodules (#104)

* Updated submodules to versions as of 15 Jan 2025

* Updated submodules as of 21 Jan 2025, and added baroclinic run to github workflow

* Updated submodules as of 5  09:49 March 2025

* Reverting changes to build_gaea_c5_gcc.sh

* Reverting changes to build_gaea_c5_gcc.sh one more thing

---------

Co-authored-by: Oliver Elbert <oliver.elbert36@gmail.com>
Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com>
Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>
Co-authored-by: Xingqiu Yuan <xingqiu.yuan@noaa.gov>
Co-authored-by: Florian Deconinck <deconinck.florian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants