Temporary Dycore dacite Config + Dycore Config Type Check Tweak [see: PyFV3 PR #88]#152
Merged
jjuyeonkim merged 3 commits intoOct 21, 2025
Conversation
8 tasks
fmalatino
approved these changes
Oct 20, 2025
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modifying the
dacite.Configfor creating aDynamicalCoreConfig. This is a proposed temporary solution to get the CI to pass for PyFV3 PR #88, which is part of NDSL Issue #64.These type_hooks are to support proposed future changes to the
DynamicalCoreConfigto allow for tuples to be created properly from lists potentially from ayaml.safe_load. Eventually, I'd like to change this to the following once PyFV3 PR #88 is merged:kwargs["dycore_config"] = DynamicalCoreConfig.from_dict(kwargs.get("dycore_config", {})where how
daciteis used is left up to the submodule via the config.Also -- Tweaking one of the pace unit tests that performs type checks in the dycore config.
How Has This Been Tested?
Existing CI tests pass
Checklist: