Skip to content

Temporary Dycore dacite Config + Dycore Config Type Check Tweak [see: PyFV3 PR #88]#152

Merged
jjuyeonkim merged 3 commits into
NOAA-GFDL:developfrom
jjuyeonkim:20251015_dycore_dacite_config
Oct 21, 2025
Merged

Temporary Dycore dacite Config + Dycore Config Type Check Tweak [see: PyFV3 PR #88]#152
jjuyeonkim merged 3 commits into
NOAA-GFDL:developfrom
jjuyeonkim:20251015_dycore_dacite_config

Conversation

@jjuyeonkim
Copy link
Copy Markdown
Collaborator

@jjuyeonkim jjuyeonkim commented Oct 16, 2025

Description
Modifying the dacite.Config for creating a DynamicalCoreConfig. This is a proposed temporary solution to get the CI to pass for PyFV3 PR #88, which is part of NDSL Issue #64.

These type_hooks are to support proposed future changes to the DynamicalCoreConfig to allow for tuples to be created properly from lists potentially from a yaml.safe_load. Eventually, I'd like to change this to the following once PyFV3 PR #88 is merged:

kwargs["dycore_config"] = DynamicalCoreConfig.from_dict(kwargs.get("dycore_config", {})
where how dacite is used is left up to the submodule via the config.

Also -- Tweaking one of the pace unit tests that performs type checks in the dycore config.

How Has This Been Tested?
Existing CI tests pass

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@jjuyeonkim jjuyeonkim marked this pull request as ready for review October 16, 2025 19:30
Copy link
Copy Markdown
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jjuyeonkim jjuyeonkim changed the title Temporary Dycore dacite Config [see: PyFV3 PR #88] Temporary Dycore dacite Config + Dycore Config Type Check Tweak [see: PyFV3 PR #88] Oct 20, 2025
@jjuyeonkim jjuyeonkim requested a review from romanc October 20, 2025 17:22
Copy link
Copy Markdown
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jjuyeonkim jjuyeonkim added this pull request to the merge queue Oct 21, 2025
Merged via the queue into NOAA-GFDL:develop with commit 20b6fbe Oct 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants