Tmp dacite.Config for PhysicsConfig + PyFV3 module update + Clean-up#153
Merged
jjuyeonkim merged 4 commits intoOct 27, 2025
Merged
Conversation
Clean up after pyFV3 PR NOAA-GFDL#88
8 tasks
fmalatino
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These are proposed modifications to get the CI to pass for PySHiELD PR #68, which is part of NDSL Issue #64.
dacite.Configfor creating aPhysicsConfig. The added type_hooks are to support proposed future changes to thePhysicsConfigto allow for tuples to be created properly from lists potentially from ayaml.safe_load. Eventually, I'd like to eventually change it to the following once PySHiELD PR #68 is merged:kwargs["physics_config"] = PhysicsConfig.from_dict(kwargs.get("physics_config", {}), where howdaciteis used is left up to the submodule via the config.How Has This Been Tested?
Existing CI tests pass
Checklist: