Skip to content

Tmp dacite.Config for PhysicsConfig + PyFV3 module update + Clean-up#153

Merged
jjuyeonkim merged 4 commits into
NOAA-GFDL:developfrom
jjuyeonkim:20251021_phys_dacite_config
Oct 27, 2025
Merged

Tmp dacite.Config for PhysicsConfig + PyFV3 module update + Clean-up#153
jjuyeonkim merged 4 commits into
NOAA-GFDL:developfrom
jjuyeonkim:20251021_phys_dacite_config

Conversation

@jjuyeonkim
Copy link
Copy Markdown
Collaborator

@jjuyeonkim jjuyeonkim commented Oct 21, 2025

Description
These are proposed modifications to get the CI to pass for PySHiELD PR #68, which is part of NDSL Issue #64.

  1. Modifying the dacite.Config for creating a PhysicsConfig. The added type_hooks are to support proposed future changes to the PhysicsConfig to allow for tuples to be created properly from lists potentially from a yaml.safe_load. Eventually, I'd like to eventually change it to the following once PySHiELD PR #68 is merged:kwargs["physics_config"] = PhysicsConfig.from_dict(kwargs.get("physics_config", {}), where how dacite is used is left up to the submodule via the config.
  2. Also, there is clean-up from Pace PR Temporary Dycore dacite Config + Dycore Config Type Check Tweak [see: PyFV3 PR #88] #152 , which is why the pyFV3 submodule has been updated to get the most recent changes from PyFV3 PR #68.

How Has This Been Tested?
Existing CI tests pass

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules - Dependent on: PyFV3 PR #90 to fix linting error
  • New check tests, if applicable, are included

@jjuyeonkim jjuyeonkim changed the title Tmp dacite.Config for PhysicsConfig + PyFV3 module update Tmp dacite.Config for PhysicsConfig + PyFV3 module update + Clean-up Oct 21, 2025
@jjuyeonkim jjuyeonkim marked this pull request as ready for review October 22, 2025 21:05
Copy link
Copy Markdown
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jjuyeonkim jjuyeonkim added this pull request to the merge queue Oct 24, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 24, 2025
@jjuyeonkim jjuyeonkim added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NOAA-GFDL:develop with commit 85a792c Oct 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants