Address compilation warnings and merge develop into dev/ufs-weather-model#1534
Conversation
…g in WW3 and operational workflow (NOAA-EMC#1522)
…ility issues with implicit time stepping on unstructured meshes. (NOAA-EMC#1528)
…rocedure referencing (NOAA-EMC#1521)
…AUSS_SEIDEL_BLOCK to address reproducibility issues (NOAA-EMC#1524)
…fswmplusfixwarnings
JessicaMeixner-NOAA
left a comment
There was a problem hiding this comment.
While typically not required, to ensure we don't have unanticipated diffs with GFSv17, I also ran the WW3 regression tests. The diffs are:
**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (17 files differ)
mww3_test_03/./work_PR1_MPI_d2 (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2 (15 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2 (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c (1 files differ)
mww3_test_03/./work_PR1_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2 (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2 (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c (1 files differ)
mww3_test_09/./work_MPI_ASCII (0 files differ)
ww3_tp2.10/./work_MPI_OMPH (6 files differ)
ww3_tp2.21/./work_b_metis (1 files differ)
ww3_tp2.3/./work_PR2_UQ (6 files differ)
ww3_tp2.3/./work_PR1 (6 files differ)
ww3_tp2.3/./work_PR2_UQ_MPI (6 files differ)
ww3_tp2.3/./work_PR1_MPI (6 files differ)
ww3_tp2.3/./work_PR3_UQ (6 files differ)
ww3_tp2.3/./work_PR3_UQ_MPI (6 files differ)
ww3_tp2.3/./work_PR3_UNO (6 files differ)
ww3_tp2.3/./work_PR3_UNO_MPI (6 files differ)
ww3_tp2.3/./work_PR2_UNO_MPI (6 files differ)
ww3_tp2.3/./work_PR2_UNO (6 files differ)
ww3_tp2.6/./work_ST4_ASCII (0 files differ)
ww3_ufs1.1/./work_unstr_b (808 files differ)
ww3_ufs1.1/./work_unstr_a (797 files differ)
ww3_ufs1.1/./work_unstr_d (directory not found)
ww3_ufs1.1/./work_unstr_c (807 files differ)
ww3_ufs1.3/./work_a (3 files differ)
Note the tp2.3 diffs are from #1517
and the ufs1.1 are from #1507
There are no "answer" changes for what will be run in GFSv17, however we do have fixes for compiler warnings.
Additionally updates for using implicit scheme (if chosen) are added. These are currently not used but now would be available in the code.
…remove Intel #8889 warnings (NOAA-EMC#1536)
|
@mingchen-NOAA Could you please update the WW3 hash for this PR so that we can pull it into WM #2979 and begin testing? |
|
@gspetro-NOAA It is already up-to-date with dev/ufs-weather-model branch. In WW3, we have a separate branch for UFSWM, see comparison. |
|
Testing completed successfully on WM parent PR 2979. This PR can be merged. |
b6db1fc
into
NOAA-EMC:dev/ufs-weather-model
Pull Request Summary
This addresses warnings during compilation for GFSv17.
Description
This PR merges in develop and fixes compilation warnings:
Issue(s) addressed
No specifically but solves multiple for dev/ufs-weather-model branch
Commit Message
Merging a PR and develop to fix warnings during compilation
Check list
Testing