Skip to content

Solve GNU & Intel build and allow to compile with switches S and T#1509

Merged
JessicaMeixner-NOAA merged 27 commits into
NOAA-EMC:developfrom
alcoat:develop
Nov 5, 2025
Merged

Solve GNU & Intel build and allow to compile with switches S and T#1509
JessicaMeixner-NOAA merged 27 commits into
NOAA-EMC:developfrom
alcoat:develop

Conversation

@alcoat
Copy link
Copy Markdown
Contributor

@alcoat alcoat commented Oct 16, 2025

Pull Request Summary

  • Little changes to compile with switches S and T since mpi_f08 migration.
  • Solved GNU & Intel build in github actions

Description

Intel build is not supported by Ubuntu lastest with is revision 24.04 so back to ubuntu-22.04
The S and T flags can know be used to debug Wavewatch3

Issue(s) addressed

Commit Message

Solve GNU & Intel build and allow to compile with switches S and T

Check list

Testing

  • How were these changes tested?
    The action workflows are running well
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    Yes, regtest_gnu workflow is running
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    Switches S and T can be usefull to debug the runs, however the code needed some updates which are in this pull request

@alcoat alcoat changed the title Allow to compile with switches S and T Solve GNU build and allow to compile with switches S and T Oct 20, 2025
@alcoat alcoat changed the title Solve GNU build and allow to compile with switches S and T Solve GNU & Intel build and allow to compile with switches S and T Oct 21, 2025
@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

@alcoat thanks for this PR. Please revert/use the PR template. If you need you can find it here: https://github.com/NOAA-EMC/WW3/blob/develop/.github/pull_request_template.md

Once that is complete we can start reviewing your PR.

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

Thanks for updating the PR template. Can you please fill out the testing information section as well?

Comment thread .github/workflows/gnu.yml
Comment thread .github/workflows/intel.yml
Comment thread .github/workflows/regtest_gnu.yml
Comment thread model/src/w3iogrmd.F90 Outdated
Comment thread model/src/w3strkmd.F90 Outdated
@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (18 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit 639b398 into NOAA-EMC:develop Nov 5, 2025
22 checks passed
@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

Thank you @alcoat for the updates! It's great to have the CI working again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

intel.yml CI workflow must change to support new distribution method, new LLVM compilers

2 participants