Skip to content

Update regtest ww3_ufs1.1#1507

Merged
mingchen-NOAA merged 13 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:updatert
Oct 21, 2025
Merged

Update regtest ww3_ufs1.1#1507
mingchen-NOAA merged 13 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:updatert

Conversation

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Oct 15, 2025

Pull Request Summary

Updating regtest ww3_ufs1.1

Description

This PR updates ww3_ufs1.1 unstructured b and c grids to match more closely with currently used options. Additionally an extra switch was added that is needed for additional testin.

Issue(s) addressed

No issue.

Commit Message

Update regtest ww3_ufs1.1

Check list

Testing

  • How were these changes tested? Ursa Intel
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? Yes
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)

ww3_ufs1.1 unstructured tests will all change results.

ww3_ufs1.1/./work_unstr_b                     (808 files differ)
ww3_ufs1.1/./work_unstr_a                     (797 files differ)
ww3_ufs1.1/./work_unstr_c                     (807 files differ)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (18 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.1/./work_unstr_b                     (808 files differ)
ww3_ufs1.1/./work_unstr_a                     (797 files differ)
ww3_ufs1.1/./work_unstr_c                     (807 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

matrixCompFull.txt
matrixCompSummary.txt

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

I am starting test it on Hercules Intel

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

All tests passed. No unexpected differences were observed.
Known differences:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (18 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (15 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

Expected changes from this PR:

ww3_ufs1.1/./work_unstr_c                     (807 files differ)
ww3_ufs1.1/./work_unstr_a                     (797 files differ)
ww3_ufs1.1/./work_unstr_b                     (808 files differ)

matrixCompFull.txt
matrixCompSummary.txt

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

@kestonsmith-noaa Please let me know if you have any comments. If not, I’ll go ahead and merge this PR.

@kestonsmith-noaa
Copy link
Copy Markdown
Collaborator

kestonsmith-noaa commented Oct 17, 2025

Suggested changes look fine and the changes in output look to be in the range expected given changes in parameter values. One minor note: The ww3_ufs1.1/info file suggests base switches(lines 37-41):

Model should be compiled with the switches :

NCO NOGRB DIST MPI SCRIP SCRIPNC WRST PR3 UQ FLX0 SEED ST4 STAB0
NL1 BT1 DB1 MLIM FLD2 TR0 BS0 RWND WNX1 WNT1 CRX1 CRT1 O0 O1 O2 O3 O4
O5 O6 O7 O14 O15 IC0 IS0 REF0.

which is no longer consistent with ww3_ufs1.1/input_unstr/switch_PDLIB. Perhaps the ww3_ufs1.1/info file should be updated to not cause confusion going forward (or this could be brought up to date at later).

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator Author

Good suggestion! Thanks @kestonsmith-noaa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants