Skip to content

Bugfix multi#1525

Merged
mingchen-NOAA merged 2 commits into
NOAA-EMC:developfrom
umr-lops:bugfix_multi
Nov 7, 2025
Merged

Bugfix multi#1525
mingchen-NOAA merged 2 commits into
NOAA-EMC:developfrom
umr-lops:bugfix_multi

Conversation

@mickaelaccensi
Copy link
Copy Markdown
Collaborator

Pull Request Summary

initialize some variables to avoid ww3_multi to crash with gnu compiler

Description

initialize some variables to avoid ww3_multi to crash with gnu compiler

Issue(s) addressed

fix issue #1519

Commit Message

initialize some variables to avoid ww3_multi to crash with gnu compiler

Check list

Testing

  • How were these changes tested? all regtests
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) all
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? datarmor with intel and gnu
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@mingchen-NOAA mingchen-NOAA self-requested a review November 6, 2025 15:22
@mickaelaccensi
Copy link
Copy Markdown
Collaborator Author

@mingchen-NOAA could you test and merge this PR as soon as possible, we need it for the WW3 training course which is in a few days. Thanks !

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

@mickaelaccensi I will test it today!

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

Running regression tests on Ursa Intel and GNU.

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

Regression tests done. No error was observed in both Intel and GNU. Running matrix comparisons.

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

Ursa Intel passed. No unexpected differences.

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UNO_MPI_d2                     (19 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (5 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (2 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

Ursa GNU passed. No unexpected difference.

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UNO_MPI_d2                     (7 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (10 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (10 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (5 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_tp2.7/./work_ST0                     (1 files differ)
ww3_ufs1.3/./work_a                     (28 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@mingchen-NOAA mingchen-NOAA merged commit ac2f91c into NOAA-EMC:develop Nov 7, 2025
22 checks passed
@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

@mickaelaccensi This PR has been merged. Thank you very much!

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

@mickaelaccensi Can we close the issue #1519?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants