Fix SCOTCH and MPI_COMM_RANK explicit-interface warnings for debug build#1531
Merged
JessicaMeixner-NOAA merged 4 commits intoNov 21, 2025
Merged
Conversation
JessicaMeixner-NOAA
approved these changes
Nov 19, 2025
This was referenced Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR addresses several explicit-interface warnings encountered when building WW3 and the operational workflow in debug mode.
Description
To fix the Intel warning
#8889: Explicit interface or EXTERNAL declaration is required. [SCOTCH_PARMETIS_V3_PARTGEOMKWAY]inyowpdlibmain.F90, a proper interface block has been added for theSCOTCH_ParMETIS_V3_PartGeomKway(andSCOTCHFParMETIS_V3_PartGeomKwaywhen applicable) routines used inrunParmetis. These interfaces replace the previous implicit external calls and allow the compiler to perform full argument checking.To address the debug build warning
#8889: Explicit interface or EXTERNAL declaration is required. [MPI_COMM_RANK]inw3profsmd_pdlib.F90whereMPI_COMM_RANKlacked an explicit interface. The routine was being called without being imported frommpi_f08, causing Intel warnings. The fix addsMPI_COMM_RANKto the usempi_f08, only:list so the compiler receives the correct explicit interface and the warning is resolved.No answer-changing behavior is expected from this PR; it only removes a build warning.
Issue(s) addressed
addressing issue #1501
Commit Message
fix SCOTCH and MPI_COMM_RANK explicit-interface warnings for debug build
Check list
Testing
Hercules-Intel: no errors or unexpected differences were observed
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt
Hercules-GNU: no errors or unexpected differences were observed
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt