Skip to content

Fix SCOTCH and MPI_COMM_RANK explicit-interface warnings for debug build#1531

Merged
JessicaMeixner-NOAA merged 4 commits into
NOAA-EMC:developfrom
mingchen-NOAA:ww3/fixWarnings
Nov 21, 2025
Merged

Fix SCOTCH and MPI_COMM_RANK explicit-interface warnings for debug build#1531
JessicaMeixner-NOAA merged 4 commits into
NOAA-EMC:developfrom
mingchen-NOAA:ww3/fixWarnings

Conversation

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

@mingchen-NOAA mingchen-NOAA commented Nov 19, 2025

Pull Request Summary

This PR addresses several explicit-interface warnings encountered when building WW3 and the operational workflow in debug mode.

Description

To fix the Intel warning #8889: Explicit interface or EXTERNAL declaration is required. [SCOTCH_PARMETIS_V3_PARTGEOMKWAY] in yowpdlibmain.F90, a proper interface block has been added for the SCOTCH_ParMETIS_V3_PartGeomKway (and SCOTCHFParMETIS_V3_PartGeomKway when applicable) routines used in runParmetis. These interfaces replace the previous implicit external calls and allow the compiler to perform full argument checking.

To address the debug build warning #8889: Explicit interface or EXTERNAL declaration is required. [MPI_COMM_RANK] in w3profsmd_pdlib.F90 where MPI_COMM_RANK lacked an explicit interface. The routine was being called without being imported from mpi_f08, causing Intel warnings. The fix adds MPI_COMM_RANK to the use mpi_f08, only: list so the compiler receives the correct explicit interface and the warning is resolved.

No answer-changing behavior is expected from this PR; it only removes a build warning.

Issue(s) addressed

addressing issue #1501

Commit Message

fix SCOTCH and MPI_COMM_RANK explicit-interface warnings for debug build

Check list

Testing

  • How were these changes tested? Matrix
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? Hercules Intel and GNU
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

Hercules-Intel: no errors or unexpected differences were observed

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (15 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

Hercules-GNU: no errors or unexpected differences were observed

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_d2                     (13 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (18 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (13 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ts1/./work_ST4_WRT                     (1 files differ)
ww3_ufs1.3/./work_a                     (27 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

Comment thread model/src/PDLIB/yowpdlibmain.F90 Outdated
@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit 44a3409 into NOAA-EMC:develop Nov 21, 2025
22 checks passed
@mingchen-NOAA mingchen-NOAA deleted the ww3/fixWarnings branch January 13, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants