Fix precompilation errors with Julia 1.3#1244
Conversation
|
The test errors are caused by GridLayoutBase, more concretely by https://github.com/jkrumbiegel/GridLayoutBase.jl/blob/b514330a891bfaabc809d8742ee596f9206c0e78/src/gridlayout.jl#L1346. |
|
I opened a PR: jkrumbiegel/GridLayoutBase.jl#22 |
| fail-fast: false | ||
| matrix: | ||
| version: | ||
| - '1.3' |
There was a problem hiding this comment.
I am wondering if maybe you want to just test Julia '1.3' (the lower bound) and '1' (the latest stable version)?
There was a problem hiding this comment.
no I decided against '1', because I find it confusing and not very helpful... The latest stable version doesn't change often enough, that its really worth having such a short cut ;)
There was a problem hiding this comment.
Fair enough :) But is it actually helpful to test '1.5'?
There was a problem hiding this comment.
Ah, if we test 1.3, probably not ;)
|
Hmm, it seems GridLayoutBase 0.6.1 which contains the fix is not used in the tests. |
|
Makie tests pass with Julia 1.3 🎉 It depends on GeometryBasics 0.4 (and compatible versions of GridLayoutBase and MeshIO) though, which causes many deprecation warnings in the tests. Even though they are not user facing, we should probably fix them first, either in this PR or in #1132. |
|
Cool, yeah we should really merge that PR! |
|
@knuesel is on vaccation, but maybe we could also renew that PR with the given script |
|
I opened #1252. |
|
Oh damn... Seems like GeometryBasics also isn't 1.3 ready anymore? :D |
|
It is, and it works successfully in the Makie, CairoMakie, and WGLMakie tests. I am a bit surprised about these test failures with GLMakie - it worked before we eliminated the deprecation warnings yesterday 😄 |
|
I think this line somehow triggers to fall back to the latest registered Makie version, and not the locally dev'ed one: ERROR: LoadError: Unsatisfiable requirements detected for package GeometryBasics [5c1252a2]:
GeometryBasics [5c1252a2] log:
├─possible versions are: [0.1.0-0.1.3, 0.2.0-0.2.15, 0.3.0-0.3.13, 0.4.0-0.4.1] or uninstalled
├─restricted to versions * by ReferenceTests [d37af2e0], leaving only versions [0.1.0-0.1.3, 0.2.0-0.2.15, 0.3.0-0.3.13, 0.4.0-0.4.1]
│ └─ReferenceTests [d37af2e0] log:
│ ├─possible versions are: 0.1.0 or uninstalled
│ └─ReferenceTests [d37af2e0] is fixed to version 0.1.0
├─restricted to versions 0.4.1-0.4 by GLMakie [e9467ef8], leaving only versions 0.4.1
│ └─GLMakie [e9467ef8] log:
│ ├─possible versions are: 0.4.5 or uninstalled
│ └─GLMakie [e9467ef8] is fixed to version 0.4.5
└─restricted by compatibility requirements with Makie [ee78f7c6] to versions: 0.3.5-0.3.13 — no versions left
└─Makie [ee78f7c6] log:
├─possible versions are: [0.9.0-0.9.6, 0.10.0, 0.11.0-0.11.2, 0.12.0, 0.13.0-0.13.14, 0.14.0-0.14.2, 0.15.0-0.15.1] or uninstalled
├─restricted to versions * by ReferenceTests [d37af2e0], leaving only versions [0.9.0-0.9.6, 0.10.0, 0.11.0-0.11.2, 0.12.0, 0.13.0-0.13.14, 0.14.0-0.14.2, 0.15.0-0.15.1]
│ └─ReferenceTests [d37af2e0] log: see above
└─restricted to versions 0.15.1 by GLMakie [e9467ef8], leaving only versions 0.15.1
└─GLMakie [e9467ef8] log: see aboveNote the: But I'm not really sure why this works for the other backends, which should do exactly the same... |
|
I made the GLMakie test environment similar to the one of WGLMakie and removed the submodule references to Makie, GeometryBasics, and FileIO and instead loaded them explicitly. It seems this fixed the test error (at least no errors so far). |
|
Yay, thanks for all the effort :D |
|
Is it possible to release a new version of Makie with the fixes for Julia 1.3? I would like to support Makie 0.15 in AbstractGPsMakie without dropping 1.3 🙂 |
2 participants
Currently precompilation on Julia 1.3 errors even though Makie 0.15.0 states that it is compatible with Julia 1.3. This PR fixes the issue which was introduced in #1118 and adds CI tests with Julia 1.3 to avoid regressions in the future.