Support Julia 1.3#76
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 93.44% 93.17% -0.28%
==========================================
Files 8 8
Lines 412 410 -2
==========================================
- Hits 385 382 -3
- Misses 27 28 +1
Continue to review full report at Codecov.
|
Contributor
Author
|
Test errors look similar to JuliaIO/FileIO.jl#345, maybe it's an issue upstream. I'll investigate it more closely when I'm back at my computer. |
Contributor
Author
|
Tests pass now with Julia 1.3. The problem was that |
Contributor
Author
|
@SimonDanisch The PR is ready for review 🙂 |
Member
|
Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MeshIO holds back GeometryBasics (and hence also GridLayoutBase) in the tests of Makie with Julia 1.3 (MakieOrg/Makie.jl#1244). CI should reveal any potential issues with Julia 1.3 🙂