Skip to content

Support Julia 1.3#76

Merged
SimonDanisch merged 5 commits into
JuliaIO:masterfrom
devmotion:patch-1
Aug 23, 2021
Merged

Support Julia 1.3#76
SimonDanisch merged 5 commits into
JuliaIO:masterfrom
devmotion:patch-1

Conversation

@devmotion
Copy link
Copy Markdown
Contributor

MeshIO holds back GeometryBasics (and hence also GridLayoutBase) in the tests of Makie with Julia 1.3 (MakieOrg/Makie.jl#1244). CI should reveal any potential issues with Julia 1.3 🙂

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 22, 2021

Codecov Report

Merging #76 (d0a131e) into master (97ce3af) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   93.44%   93.17%   -0.28%     
==========================================
  Files           8        8              
  Lines         412      410       -2     
==========================================
- Hits          385      382       -3     
- Misses         27       28       +1     
Impacted Files Coverage Δ
src/MeshIO.jl 100.00% <100.00%> (ø)
src/io/obj.jl 96.77% <100.00%> (ø)
src/precompile.jl 0.00% <0.00%> (-27.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f269e...d0a131e. Read the comment docs.

@devmotion
Copy link
Copy Markdown
Contributor Author

Test errors look similar to JuliaIO/FileIO.jl#345, maybe it's an issue upstream. I'll investigate it more closely when I'm back at my computer.

@devmotion
Copy link
Copy Markdown
Contributor Author

Tests pass now with Julia 1.3. The problem was that filter(f, ::Tuple) is not defined in Julia 1.3. I used the opportunity to clean the list of imports and fix the deprecations in the tests as well.

@devmotion
Copy link
Copy Markdown
Contributor Author

@SimonDanisch The PR is ready for review 🙂

@SimonDanisch
Copy link
Copy Markdown
Member

Thank you :)

@SimonDanisch SimonDanisch merged commit e2f20a4 into JuliaIO:master Aug 23, 2021
@devmotion devmotion deleted the patch-1 branch August 23, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants