Skip to content

Switch to GeometryBasics 0.4.1#1252

Merged
SimonDanisch merged 4 commits into
MakieOrg:masterfrom
devmotion:dw/geometrybasics
Aug 23, 2021
Merged

Switch to GeometryBasics 0.4.1#1252
SimonDanisch merged 4 commits into
MakieOrg:masterfrom
devmotion:dw/geometrybasics

Conversation

@devmotion
Copy link
Copy Markdown
Contributor

This is an updated version of #1132. I reran the script (JuliaGeometry/GeometryBasics.jl#97 (comment)) and added the deprecation warnings for Quaternionf0, RGBf0, and RGBAf0 from the previous PR.

@devmotion
Copy link
Copy Markdown
Contributor Author

@SimonDanisch I think this PR is ready for review 🙂

As in the previous PR, I reexported the deprecated bindings from GLMakie etc. to avoid a breaking change. Unfortunately, this leads to deprecations warnings such as https://github.com/JuliaPlots/Makie.jl/pull/1252/checks?check_run_id=3402333581#step:7:195 in the tests. However, users should not notice it since they won't see the warnings 🤷

@SimonDanisch
Copy link
Copy Markdown
Member

Awesome :) I think we should re-export the old names with a depwarn?

@devmotion
Copy link
Copy Markdown
Contributor Author

Ah yeah, so far only the names defined in Makie were deprecated and these deprecations were reexported by CairoMakie etc. In the last commit I also reexported the deprecated bindings from GeometryBasics in Makie, so Vec3f0 etc. should be still available if one loads Makie but show a deprecation warning (if warnings are enabled). And they should be reexported by CairoMakie etc. automatically.

@devmotion
Copy link
Copy Markdown
Contributor Author

I just checked with julia --depwarn=yes, and it seems to work 😄

julia> using GLMakie
[ Info: Precompiling GLMakie [e9467ef8-e4e7-5192-8a1a-b1aee30e663a]
WARNING: importing deprecated binding GeometryBasics.FRect into Makie.
WARNING: GeometryBasics.FRect is deprecated, use Rectf instead.
  likely near none:1
WARNING: importing deprecated binding Makie.FRect into GLMakie.
WARNING: importing deprecated binding GeometryBasics.FRect2D into Makie.
WARNING: GeometryBasics.FRect2D is deprecated, use Rect2f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.FRect2D into GLMakie.
WARNING: importing deprecated binding GeometryBasics.FRect3D into Makie.
WARNING: GeometryBasics.FRect3D is deprecated, use Rect3f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.FRect3D into GLMakie.
WARNING: importing deprecated binding GeometryBasics.IRect into Makie.
WARNING: GeometryBasics.IRect is deprecated, use Recti instead.
  likely near none:1
WARNING: importing deprecated binding Makie.IRect into GLMakie.
WARNING: importing deprecated binding GeometryBasics.IRect2D into Makie.
WARNING: GeometryBasics.IRect2D is deprecated, use Rect2i instead.
  likely near none:1
WARNING: importing deprecated binding Makie.IRect2D into GLMakie.
WARNING: importing deprecated binding GeometryBasics.IRect3D into Makie.
WARNING: GeometryBasics.IRect3D is deprecated, use Rect3i instead.
  likely near none:1
WARNING: importing deprecated binding Makie.IRect3D into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Point2f0 into Makie.
WARNING: GeometryBasics.Point2f0 is deprecated, use Point2f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Point2f0 into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Point3f0 into Makie.
WARNING: GeometryBasics.Point3f0 is deprecated, use Point3f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Point3f0 into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Point4f0 into Makie.
WARNING: GeometryBasics.Point4f0 is deprecated, use Point4f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Point4f0 into GLMakie.
WARNING: Makie.Quaternionf0 is deprecated, use Quaternionf instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Quaternionf0 into GLMakie.
WARNING: Makie.RGBAf0 is deprecated, use RGBAf instead.
  likely near none:1
WARNING: importing deprecated binding Makie.RGBAf0 into GLMakie.
WARNING: Makie.RGBf0 is deprecated, use RGBf instead.
  likely near none:1
WARNING: importing deprecated binding Makie.RGBf0 into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Rect2D into Makie.
WARNING: GeometryBasics.Rect2D is deprecated, use Rect2 instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Rect2D into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Rect3D into Makie.
WARNING: GeometryBasics.Rect3D is deprecated, use Rect3 instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Rect3D into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Vec2f0 into Makie.
WARNING: GeometryBasics.Vec2f0 is deprecated, use Vec2f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Vec2f0 into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Vec3f0 into Makie.
WARNING: GeometryBasics.Vec3f0 is deprecated, use Vec3f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Vec3f0 into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Vec4f0 into Makie.
WARNING: GeometryBasics.Vec4f0 is deprecated, use Vec4f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Vec4f0 into GLMakie.

julia> Vec3f0
WARNING: GeometryBasics.Vec3f0 is deprecated, use Vec3f instead.
  likely near REPL[3]:1
Vec{3, Float32}

@SimonDanisch
Copy link
Copy Markdown
Member

Alright lets do this!!!

@SimonDanisch SimonDanisch merged commit 6b71a7f into MakieOrg:master Aug 23, 2021
@devmotion devmotion deleted the dw/geometrybasics branch August 23, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants