Skip to content

Replace f0 type suffix with f and rename Rect types#1132

Closed
knuesel wants to merge 6 commits into
MakieOrg:masterfrom
knuesel:replace-f0-f
Closed

Replace f0 type suffix with f and rename Rect types#1132
knuesel wants to merge 6 commits into
MakieOrg:masterfrom
knuesel:replace-f0-f

Conversation

@knuesel
Copy link
Copy Markdown

@knuesel knuesel commented Jul 16, 2021

If these changes are OK with you, I'll continue with PRs for MathTeXEngine, Animations, AlgebraOfGraphics and FreeTypeAbstraction.

@knuesel knuesel changed the title Replace f0 type suffix with f Replace f0 type suffix with f and rename Rect types Jul 19, 2021
@SimonDanisch
Copy link
Copy Markdown
Member

Oh boi, this PR is of course super sensitive to any other PR getting merged :-O I hope you have a replace regex to run again, instead of running a nasty resolve conflict?

@knuesel
Copy link
Copy Markdown
Author

knuesel commented Jul 20, 2021

Yes I have a script with regexes :) I'll post it tomorrow morning (don't have access to the computer right now).

@knuesel
Copy link
Copy Markdown
Author

knuesel commented Jul 21, 2021

I've posted the script in the PR description at JuliaGeometry/GeometryBasics.jl#97.

I'll update the PR here whenever another PR is merged, it's no trouble at all (though right now I'm waiting for Makie's dependencies to be ready).

@knuesel
Copy link
Copy Markdown
Author

knuesel commented Jul 26, 2021

@SimonDanisch this should be ready now (the relevant dependents have upgraded to GeometryBasics 0.4.1).

@SimonDanisch
Copy link
Copy Markdown
Member

I guess this still needs GridLayoutBase to get an upgrade?

@knuesel
Copy link
Copy Markdown
Author

knuesel commented Jul 26, 2021

@SimonDanisch it should work with GridLayoutBase 0.6.0 which was released earlier today. I guess it's a registry update/cache issue: the checks that started a few minutes later were successful. Maybe try again?

Edit: still giving errors... Disabling PkgServer with JULIA_PKG_SERVER="" fixes it.

@SimonDanisch
Copy link
Copy Markdown
Member

Replaced by #1252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants