Fix errors with Julia 1.3#22
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 87.00% 87.61% +0.60%
==========================================
Files 10 10
Lines 1170 1171 +1
==========================================
+ Hits 1018 1026 +8
+ Misses 152 145 -7
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an error with Julia 1.3 (MakieOrg/Makie.jl#1244 (comment)). I don't think there's any harm with using
firstinstead ofonlysince it is already ensured that this branch is only reached if the array contains only a single element. I also corrected the Julia lower bound to 1.3 since older versions are not supported (GeometryBasics 0.4.1 requires Julia 1.3).