[release-1.12] Backports for 1.12#4563
Merged
IanButterworth merged 14 commits intorelease-1.12from Dec 16, 2025
Merged
Conversation
The code here appeared to be untested and broke whenever something actually used it.
Example backtrace:
```
julia> JLLPrefixes.collect_artifact_paths(["ripgrep_jll"])
ERROR: MethodError: no method matching haskey(::Vector{Base.UUID}, ::String)
The function `haskey` exists, but no method is defined for this combination of argument types.
Closest candidates are:
haskey(::Pkg.Types.Manifest, ::Any)
@ Pkg ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/Pkg/src/Types.jl:323
haskey(::REPL.Terminals.TTYTerminal, ::Any)
@ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/Terminals.jl:155
haskey(::LibGit2.CachedCredentials, ::Any)
@ LibGit2 ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/LibGit2/src/types.jl:1357
...
Stacktrace:
[1] fixups_from_projectfile!(ctx::Pkg.Types.Context)
@ Pkg.Operations ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/Pkg/src/Operations.jl:238
[2] add(ctx::Pkg.Types.Context, pkgs::Vector{…}, new_git::Set{…}; allow_autoprecomp::Bool, preserve::Pkg.Types.PreserveLevel, platform::Base.BinaryPlatforms.Platform, target::Symbol)
@ Pkg.Operations ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/Pkg/src/Operations.jl:1710
[3] add
@ ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/Pkg/src/Operations.jl:1680 [inlined]
[4] add(ctx::Pkg.Types.Context, pkgs::Vector{…}; preserve::Pkg.Types.PreserveLevel, platform::Base.BinaryPlatforms.Platform, target::Symbol, allow_autoprecomp::Bool, kwargs::@kwargs{…})
@ Pkg.API ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/Pkg/src/API.jl:328
```
(cherry picked from commit cae9ce0)
(cherry picked from commit 01c6f36)
IanButterworth
force-pushed
the
backports-release-1.12
branch
3 times, most recently
from
148b819 to
b69bff2
Compare
IanButterworth
commented
Dec 11, 2025
Comment on lines
-198
to
+200
| Pkg.Types.PackageSpec(name = "GMP_jll", uuid = Base.UUID("781609d7-10c4-51f6-84f2-b8444358ff6d"), version = v"6.2.0"), | ||
| Pkg.Types.PackageSpec(name = "GMP_jll", uuid = Base.UUID("781609d7-10c4-51f6-84f2-b8444358ff6d"), version = v"6.2.0+0"), | ||
| # This version of MPFR only works on Julia v1.5 | ||
| Pkg.Types.PackageSpec(name = "MPFR_jll", uuid = Base.UUID("3a97d323-0669-5f0c-9066-3539efd106a3"), version = v"4.0.2"), | ||
| Pkg.Types.PackageSpec(name = "MPFR_jll", uuid = Base.UUID("3a97d323-0669-5f0c-9066-3539efd106a3"), version = v"4.0.2+0"), |
Member
Author
There was a problem hiding this comment.
I had to add these build numbers to make these pass. I'm a bit confused about why these used to pass before this PR though.. specific VersionNumbers for JLLs that are missing the build shouldn't be found... Claude thinks it's something todo with #4470 not being on 1.12 but I'm a bit lost. Any idea @KristofferC ?
Member
There was a problem hiding this comment.
I don't really know, to me, it seems a build number should be required...
Member
Author
There was a problem hiding this comment.
Agreed. This seems correct, just not clear why it didn't fail before.
IanButterworth
force-pushed
the
backports-release-1.12
branch
from
b69bff2 to
10f6b9f
Compare
IanButterworth
force-pushed
the
backports-release-1.12
branch
from
1c21722 to
0fe4cec
Compare
(cherry picked from commit 5bfdd95)
Tests that workspace child projects with [sources] entries pointing to the parent package (e.g., path = "..") can be instantiated without errors. (cherry picked from commit d73efb1)
Commit 35c5f5b removed the code that syncs sources from manifest entries but kept the assertions checking that sources match manifest. This causes AssertionError when instantiating workspace projects with [sources] entries (e.g., path = "..") since the assertions check invariants that are no longer maintained. Fixes the error: ERROR: AssertionError: normpath(entry.path) == normpath(path) (cherry picked from commit 869d8f5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pkgis in the Manifest #4264AssertionError: normpath(entry.path) == normpath(path). Add test. #4568Need manual backport:
Contains multiple commits, manual intervention needed:
.pathfield consistently be relative manifest and convert to project relative upon writing to a project file #4427Non-merged PRs with backport label: