Don't add sources to Project.toml in 1.12#4539
Merged
KristofferC merged 3 commits intoJuliaLang:backports-release-1.12from Nov 28, 2025
Merged
Don't add sources to Project.toml in 1.12#4539KristofferC merged 3 commits intoJuliaLang:backports-release-1.12from
KristofferC merged 3 commits intoJuliaLang:backports-release-1.12from
Conversation
KristofferC
changed the base branch from
release-1.12
to
backports-release-1.12
KristofferC
merged commit 35c5f5b
into
JuliaLang:backports-release-1.12
7 of 9 checks passed
IanButterworth
added a commit
to IanButterworth/Pkg.jl
that referenced
this pull request
Dec 16, 2025
Commit 35c5f5b removed the code that syncs sources from manifest entries but kept the assertions checking that sources match manifest. This causes AssertionError when instantiating workspace projects with [sources] entries (e.g., path = "..") since the assertions check invariants that are no longer maintained. Fixes the error: ERROR: AssertionError: normpath(entry.path) == normpath(path)
IanButterworth
added a commit
that referenced
this pull request
Dec 16, 2025
Commit 35c5f5b removed the code that syncs sources from manifest entries but kept the assertions checking that sources match manifest. This causes AssertionError when instantiating workspace projects with [sources] entries (e.g., path = "..") since the assertions check invariants that are no longer maintained. Fixes the error: ERROR: AssertionError: normpath(entry.path) == normpath(path) (cherry picked from commit 869d8f5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix a problem introduced in #4513 where my cherry-pick picked up a feature change from #4225 and caused it to update the
[sources]entry in theProject.tomlfile whendev-ing a package or adding it from a URL.I found the offending lines that updated the project during
write_end, deleted them, and added a test to make sure the sources don't get added. This test passes for me locally with this change and fails locally without the change.My hope is that this will let us keep the important part of the backported bugfix fix from #4513.