Skip to content

[release-1.12] Fix AssertionError: normpath(entry.path) == normpath(path). Add test.#4568

Closed
IanButterworth wants to merge 2 commits intoJuliaLang:release-1.12from
IanButterworth:ib/fix_1.12
Closed

[release-1.12] Fix AssertionError: normpath(entry.path) == normpath(path). Add test.#4568
IanButterworth wants to merge 2 commits intoJuliaLang:release-1.12from
IanButterworth:ib/fix_1.12

Conversation

@IanButterworth
Copy link
Copy Markdown
Member

@IanButterworth IanButterworth commented Dec 16, 2025

#4539 removed the code that syncs sources from manifest entries but kept the assertions checking that sources match manifest. This causes AssertionError when instantiating workspace projects with [sources] entries (e.g., path = "..") since the assertions check invariants that are no longer maintained.

Fixes the error:

ERROR: AssertionError: normpath(entry.path) == normpath(path)



Commit 35c5f5b removed the code that syncs sources from manifest entries
but kept the assertions checking that sources match manifest. This causes
AssertionError when instantiating workspace projects with [sources] entries
(e.g., path = "..") since the assertions check invariants that are no
longer maintained.

Fixes the error:
ERROR: AssertionError: normpath(entry.path) == normpath(path)
Tests that workspace child projects with [sources] entries pointing to the
parent package (e.g., path = "..") can be instantiated without errors.
@IanButterworth
Copy link
Copy Markdown
Member Author

IanButterworth commented Dec 16, 2025

Testing the added test without the fix #4569 (confirmed)

@IanButterworth IanButterworth changed the title [release-1.12] Fix AssertionError: normpath(entry.path) == normpath(path) [release-1.12] Fix AssertionError: normpath(entry.path) == normpath(path). Add test. Dec 16, 2025
@github-project-automation github-project-automation Bot moved this from New to In review in Pkg.jl Dec 16, 2025
@IanButterworth
Copy link
Copy Markdown
Member Author

Folded into #4563

@github-project-automation github-project-automation Bot moved this from In review to Done in Pkg.jl Dec 16, 2025
asinghvi17 added a commit to JuliaGeo/ConservativeRegridding.jl that referenced this pull request Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants