fix: fixup historical stdlibs in manifest#4558
Merged
IanButterworth merged 1 commit intoJuliaLang:masterfrom Dec 9, 2025
Merged
fix: fixup historical stdlibs in manifest#4558IanButterworth merged 1 commit intoJuliaLang:masterfrom
IanButterworth merged 1 commit intoJuliaLang:masterfrom
Conversation
Member
|
If this works, I'd be ok with hot-patching this in BinaryBuilder with an |
Member
|
A test would be good. |
Contributor
Author
|
I don't know how to fully test this, the only test that was added in #4264 still seems to work (in the sense that it doesn't error). I am still trying to figure out what conditions would be needed for the inner |
Member
|
Yeah I think you're right |
IanButterworth
approved these changes
Dec 9, 2025
IanButterworth
pushed a commit
that referenced
this pull request
Dec 11, 2025
(cherry picked from commit 01c6f36)
13 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 19, 2025
(cherry picked from commit 01c6f36)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
p.depsin this branch is aVector{Base.UUID}soname in p.depswill always be false (but it doesn't error like before #4264).The type is from
StdlibInfoin HistoricalStdlibVersions.I don't really know how to test that this works correctly.
cc: @Keno @giordano
It would also be great if this could make it's way into 1.12 since we are running into the original issue with
MethodError: no method matching haskey(::Vector{Base.UUID}, ::String).