Skip to content

fix: fixup historical stdlibs in manifest#4558

Merged
IanButterworth merged 1 commit intoJuliaLang:masterfrom
benlorenz:bl/fixupfixup
Dec 9, 2025
Merged

fix: fixup historical stdlibs in manifest#4558
IanButterworth merged 1 commit intoJuliaLang:masterfrom
benlorenz:bl/fixupfixup

Conversation

@benlorenz
Copy link
Copy Markdown
Contributor

p.deps in this branch is a Vector{Base.UUID} so name in p.deps will always be false (but it doesn't error like before #4264).
The type is from StdlibInfo in HistoricalStdlibVersions.

I don't really know how to test that this works correctly.

cc: @Keno @giordano

It would also be great if this could make it's way into 1.12 since we are running into the original issue with MethodError: no method matching haskey(::Vector{Base.UUID}, ::String).

@giordano
Copy link
Copy Markdown
Member

giordano commented Dec 9, 2025

If this works, I'd be ok with hot-patching this in BinaryBuilder with an @eval guarded by version checks.

@giordano giordano added binarybuilder Related to the use of Pkg in BinaryBuilder backport 1.12 backport 1.13 labels Dec 9, 2025
@IanButterworth
Copy link
Copy Markdown
Member

A test would be good.

@benlorenz
Copy link
Copy Markdown
Contributor Author

benlorenz commented Dec 9, 2025

I don't know how to fully test this, the only test that was added in #4264 still seems to work (in the sense that it doesn't error).

I am still trying to figure out what conditions would be needed for the inner if to not run.
I think it needs to be resolving for a stdlib which has a weakdep on a package that is also listed in the deps of that stdlib (both lists using the data in HistoricalStdlibVersions).
If I am reading the file correctly there is no such case and I'm not sure how that would make sense.

@IanButterworth
Copy link
Copy Markdown
Member

Yeah I think you're right

@IanButterworth IanButterworth merged commit 01c6f36 into JuliaLang:master Dec 9, 2025
11 checks passed
@github-project-automation github-project-automation Bot moved this from New to Done in Pkg.jl Dec 9, 2025
IanButterworth pushed a commit that referenced this pull request Dec 11, 2025
KristofferC pushed a commit that referenced this pull request Dec 19, 2025
@KristofferC KristofferC mentioned this pull request Dec 19, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binarybuilder Related to the use of Pkg in BinaryBuilder

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants