Skip to content

Fix is_stdlib uses when julia_version is used#4534

Merged
IanButterworth merged 2 commits intoJuliaLang:masterfrom
IanButterworth:ib/stdlib_julia_version_specific
Nov 25, 2025
Merged

Fix is_stdlib uses when julia_version is used#4534
IanButterworth merged 2 commits intoJuliaLang:masterfrom
IanButterworth:ib/stdlib_julia_version_specific

Conversation

@IanButterworth
Copy link
Copy Markdown
Member

@IanButterworth IanButterworth commented Nov 24, 2025

Fixes #4533

@IanButterworth IanButterworth added binarybuilder Related to the use of Pkg in BinaryBuilder backport 1.12 labels Nov 24, 2025
@github-project-automation github-project-automation Bot moved this to New in Pkg.jl Nov 24, 2025
@IanButterworth IanButterworth mentioned this pull request Nov 24, 2025
Merged
@IanButterworth
Copy link
Copy Markdown
Member Author

IanButterworth commented Nov 24, 2025

Woo

Stdlib add: Error During Test at /Users/runner/work/Pkg.jl/Pkg.jl/test/historical_stdlib_version.jl:315
 Unexpected Pass
 Expression: ((Pkg.dependencies())[GMP_jll_UUID]).version === v"6.2.1+1"
 Got correct result, please change to @test if no longer broken.

@IanButterworth IanButterworth force-pushed the ib/stdlib_julia_version_specific branch from 002b91a to b8b845e Compare November 24, 2025 17:28
@IanButterworth IanButterworth marked this pull request as ready for review November 24, 2025 19:58
@KristofferC
Copy link
Copy Markdown
Member

KristofferC commented Nov 24, 2025

Nice, but I thought BB wanted to get the registry results in some cases? I don't really recall now.

@IanButterworth
Copy link
Copy Markdown
Member Author

IanButterworth commented Nov 24, 2025

We could try ygg on nightly before backporting this, to check for test coverage gaps..

@IanButterworth IanButterworth merged commit 1e90f07 into JuliaLang:master Nov 25, 2025
11 checks passed
@github-project-automation github-project-automation Bot moved this from New to Done in Pkg.jl Nov 25, 2025
KristofferC pushed a commit that referenced this pull request Nov 28, 2025
@IanButterworth
Fix is_stdlib uses when julia_version is used (#4534)
861187f 
(cherry picked from commit 1e90f07)
@IanButterworth IanButterworth mentioned this pull request Dec 11, 2025
Merged
13 tasks
IanButterworth added a commit that referenced this pull request Dec 11, 2025
@IanButterworth
Fix is_stdlib uses when julia_version is used (#4534)
3337ebc 
(cherry picked from commit 1e90f07)
(cherry picked from commit 861187f)
IanButterworth added a commit that referenced this pull request Dec 11, 2025
@IanButterworth
Fix is_stdlib uses when julia_version is used (#4534)
292e0b4 
(cherry picked from commit 1e90f07)
(cherry picked from commit 861187f)
IanButterworth added a commit that referenced this pull request Dec 11, 2025
@IanButterworth
Fix is_stdlib uses when julia_version is used (#4534)
220d1b4 
(cherry picked from commit 1e90f07)
(cherry picked from commit 861187f)
IanButterworth added a commit that referenced this pull request Dec 11, 2025
@IanButterworth
Fix is_stdlib uses when julia_version is used (#4534)
4068afe 
(cherry picked from commit 1e90f07)
(cherry picked from commit 861187f)
IanButterworth added a commit that referenced this pull request Dec 11, 2025
@IanButterworth
Fix is_stdlib uses when julia_version is used (#4534)
5aeea12 
(cherry picked from commit 1e90f07)
(cherry picked from commit 861187f)
IanButterworth added a commit that referenced this pull request Dec 16, 2025
@IanButterworth
Fix is_stdlib uses when julia_version is used (#4534)
a2cfbdd 
(cherry picked from commit 1e90f07)
(cherry picked from commit 861187f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KristofferC KristofferC Awaiting requested review from KristofferC

Assignees

No one assigned

Labels

binarybuilder Related to the use of Pkg in BinaryBuilder

Projects

Pkg.jl
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pkg adds incorrect Artifacts version based on julia_version

2 participants

@IanButterworth @KristofferC