[pull] master from musescore:master #765
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #25602: Mark project as unsaved when changing solo/mute states
Display all alterated notes consistently using only sharps.
[MusicXML] reimport polychords
ZipRW. Fixed build
Make testing translations possible/easier
Fix #24957 plus new TPC transposing method
src/palette/view/widgets/palettewidget.cpp:
In member function ‘void mu::palette::PaletteWidget::applyElementAtIndex(int, Qt::KeyboardModifiers)’:
src/palette/view/widgets/palettewidget.cpp:460:28:
error: invalid use of incomplete type ‘class QWindow’
460 | mainWindow()->qWindow()->requestActivate();
| ^~
Signed-off-by: Nicolas PARLANT <[email protected]>
missing header
Resolves: #30388 Unminimising a window turns out to be difficult, if you want that the geometry is preserved when the window filled the whole screen before being minimised. Qt considers a window that happens to fill the whole screen as “maximised”; it seems that when unminimising a window, either using `show` or `setVisibility(AutomaticVisibility)`, Qt wants it to return to a “normal” state, which is not a maximised state, so the window is made a bit smaller (and it’s ugly). A plain call to `window->setWindowStates(states & ~Minimised)` seems to do exactly nothing. Instead of trying to unminimise the window, we just make sure it never gets into a minimised state at all, during geometry restoration.
Remove no-op from getNextValidInputSegment
Qt's accessibility on macOS may crash if an accessible item with the ListItem role has no parent (e.g., after setAccessibleParent(nullptr), which triggers QAccessible::ParentChanged). Internals assume the parent is valid and dereference it (see qcocoaaccessibilityelement.mm:136) Our implementation falls back to qApp->focusWindow() (AccessibilityController::parentIface()), so the parent is usually set, but when the app is inactive the crash could happen (e.g. during theme reloads or when inspected by Accessibility Inspector, or during the shutdown). This PR reduces the chance of having no accessible parent during UI changes, minimizing these crashes.
…acos Fix crash in QAccessible on macOS when parent is null
[MusicXML] handle hanging ties
Don't add invisible measure numbers to shape & skyline
Fix persistent parentheses
Restore omit lines
Fix #24922, 26612, 29611: Refactor key signatures
Co-authored-by: Roman Pudashkin <[email protected]>
See prepareReplyReceive() and waitForReplyFinished()
Fix #30602: fix applying beams to range
[API] Allow hiding individual staves in systems
print: Remove color mode override
Co-authored-by: 22justinl <[email protected]>
Co-authored-by: 22justinl <[email protected]>
1. when starting playback 2. during playback on score change 3. online sounds: always on score change
Porting 4.6.3 PRs to master
Rename lyric verse property
Remove DOM layout calls
Fix trill cue note horizontal spacing
CI. Backend. Fonts override fix
…nstrument-page Align the columns in "Create from template" to the columns in "Choose instruments" in the New Score wizard
Hovering piano keyboard shows shadow note
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
24 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )