-
Notifications
You must be signed in to change notification settings - Fork 3k
[MusicXML] reimport polychords #30054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b5dbdcd to
acd1325
Compare
src/importexport/musicxml/internal/musicxml/import/importmusicxmlpass2.cpp
Outdated
Show resolved
Hide resolved
d9b66e6 to
298330f
Compare
|
@miiizen @cbjeukendrup Would be nice if we could squeeze this in for 4.6.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also have a test for import&export please?
src/importexport/musicxml/internal/musicxml/import/importmusicxmlpass2.cpp
Outdated
Show resolved
Hide resolved
|
Definitely, I just wasn't sure if I should adjust the export test, or to add a separate one. |
298330f to
b32164d
Compare
b32164d to
97ff3f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
[MusicXML] reimport polychords
Addition to #29362 to enable import of polychords.