Fix crash in QAccessible on macOS when parent is null #30387
Merged
+14
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt's accessibility on macOS may crash if an accessible item with the ListItem role has no parent (e.g., after setAccessibleParent(nullptr), which triggers QAccessible::ParentChanged). Internals assume the parent is valid and dereference it (see qcocoaaccessibilityelement.mm:136)
Our implementation falls back to qApp->focusWindow() (AccessibilityController::parentIface()), so the parent is usually set, but when the app is inactive the crash could happen (e.g. during theme reloads or when inspected by Accessibility Inspector, or during the shutdown).
This PR reduces the chance of having no accessible parent during UI changes, minimizing these crashes.