-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix #24957 plus new TPC transposing method #30139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@XiaoMigros Besides the linked issue and perhaps some pitch editing and transposing operations, do you have any other recommendations for things that should be tested? |
|
The only logic changes have been made to transposition, ambitus pitch calculation, and general pitch calculation. Please test all sorts of pitch input options (keyboard, clicking, dragging, keyboard editing) as well as transposition through instruments, the transpose dialog and of ornaments. |
e898f74 to
8ea2cba
Compare
And use int for the pitch ranges in instrument templates.
b54f5b1 to
f87d6f7
Compare
|
Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved #24957 FIXED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice cleanups! Thanks!
|
Thank you! An apt 100th merged PR :) |
|
Ooh congratulations! |
Resolves: #24957 - Ottavas now included in ambitus calculations