Skip to content

Conversation

@XiaoMigros
Copy link
Contributor

Resolves: #24957 - Ottavas now included in ambitus calculations

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup
Copy link
Member

@XiaoMigros Besides the linked issue and perhaps some pitch editing and transposing operations, do you have any other recommendations for things that should be tested?

@XiaoMigros
Copy link
Contributor Author

XiaoMigros commented Sep 26, 2025

The only logic changes have been made to transposition, ambitus pitch calculation, and general pitch calculation. Please test all sorts of pitch input options (keyboard, clicking, dragging, keyboard editing) as well as transposition through instruments, the transpose dialog and of ornaments.

@XiaoMigros XiaoMigros force-pushed the ambitus branch 3 times, most recently from e898f74 to 8ea2cba Compare September 26, 2025 11:37
@XiaoMigros XiaoMigros force-pushed the ambitus branch 7 times, most recently from b54f5b1 to f87d6f7 Compare September 28, 2025 22:25
@zacjansheski
Copy link
Contributor

Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved

#24957 FIXED

Copy link
Member

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice cleanups! Thanks!

@cbjeukendrup cbjeukendrup merged commit c910ef6 into musescore:master Oct 8, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Needs porting in MuseScore Studio 4.7 Oct 8, 2025
@cbjeukendrup cbjeukendrup moved this from Needs porting to Done in MuseScore Studio 4.7 Oct 8, 2025
@XiaoMigros
Copy link
Contributor Author

Thank you! An apt 100th merged PR :)

@cbjeukendrup
Copy link
Member

Ooh congratulations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Ambitus does not consider ottava brackets

3 participants