Skip to content

Conversation

@ericssonpaul
Copy link

@ericssonpaul ericssonpaul commented Dec 26, 2022

Previously, when creating a new score the columns in these two tabs weren't aligned. Having them being the same is a bit more aesthetically pleasing.

Before:
Choose_instruments_before
Choose_from_template_before

After:
Choose_instruments_after
Choose_from_template_after

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup cbjeukendrup changed the title Align the rows in "Create from template" to the rows in "Choose instruments" in the New Score wizard Align the columns in "Create from template" to the columns in "Choose instruments" in the New Score wizard Dec 26, 2022
@igorkorsukov igorkorsukov force-pushed the master branch 6 times, most recently from fa1f8d3 to 525a11a Compare February 14, 2024 09:08
@cbjeukendrup cbjeukendrup force-pushed the align-template-page-and-instrument-page branch from a2c5665 to 6b4e7a8 Compare April 9, 2025 09:07
@cbjeukendrup cbjeukendrup force-pushed the align-template-page-and-instrument-page branch from 6b4e7a8 to 495148d Compare October 18, 2025 20:24
@cbjeukendrup cbjeukendrup moved this to Needs Review in MuseScore Studio 4.7 Oct 18, 2025
@avvvvve avvvvve self-requested a review October 22, 2025 15:50
@cbjeukendrup cbjeukendrup merged commit 1343966 into musescore:master Oct 22, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Needs porting in MuseScore Studio 4.7 Oct 22, 2025
@cbjeukendrup cbjeukendrup moved this from Needs porting to Done in MuseScore Studio 4.7 Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants