Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urdfdom 4.0.0, depend on tinyxml2 #158963

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jan 4, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This version of urdfdom now depends on tinyxml2 instead of tinyxml.

@scpeters
Copy link
Member Author

scpeters commented Jan 4, 2024

I'm looking into the dartsim failure; sorry I didn't build that before opening the PR

@scpeters
Copy link
Member Author

scpeters commented Jan 4, 2024

I'm looking into the dartsim failure; sorry I didn't build that before opening the PR

I've submitted a patch in dartsim/dart#1779 to fix the dartsim build. I'll wait for some maintainer feedback before using it here

@scpeters
Copy link
Member Author

scpeters commented Jan 5, 2024

I'm looking into the dartsim failure; sorry I didn't build that before opening the PR

I've submitted a patch in dartsim/dart#1779 to fix the dartsim build. I'll wait for some maintainer feedback before using it here

the patch is in #159018

@SMillerDev
Copy link
Member

The formula version (4.0.0) is newer than the version from brew livecheck (3.0.0).

Doesn't seem like you made an actual release upstream yet.

@chenrui333 chenrui333 added the pre-release Artifact is pre-release label Jan 5, 2024
@scpeters
Copy link
Member Author

scpeters commented Jan 5, 2024

The formula version (4.0.0) is newer than the version from brew livecheck (3.0.0).

Doesn't seem like you made an actual release upstream yet.

we created a tag, which is our typical release process. In the past I had experimented with creating a few Release entries, but that hasn't been consistent; usually we just create a tag. Is it required to create a Release entry in order for a tag to not be recognized as a prerelease?

@samford
Copy link
Member

samford commented Jan 5, 2024

Per the discussion on Slack, I modified the urdfdom commit to update the livecheck block to check tags using the standard regex for Git tags like 1.2.3/v1.2.3 (avoiding other tags in the repository like robot_model-1.7.1). This aligns the check with the current release process and returns 4.0.0, as expected.

@samford samford removed the pre-release Artifact is pre-release label Jan 5, 2024
scpeters and others added 3 commits January 5, 2024 15:58
Depend on tinyxml2 instead of tinyxml.

Update `livecheck` block to check tags, aligning with upstream release
process.

Co-authored-by: Sam Ford <[email protected]>
@samford samford mentioned this pull request Jan 5, 2024
6 tasks
Copy link
Contributor

github-actions bot commented Jan 5, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 5, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 5, 2024
Merged via the queue into Homebrew:master with commit 96f50dd Jan 5, 2024
12 checks passed
@scpeters scpeters deleted the urdfdom_4.0.0 branch January 5, 2024 22:19
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants