-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
urdfdom 4.0.0, depend on tinyxml2 #158963
Conversation
I'm looking into the dartsim failure; sorry I didn't build that before opening the PR |
I've submitted a patch in dartsim/dart#1779 to fix the dartsim build. I'll wait for some maintainer feedback before using it here |
the patch is in #159018 |
af4d423
to
4f8dd10
Compare
Doesn't seem like you made an actual release upstream yet. |
we created a tag, which is our typical release process. In the past I had experimented with creating a few Release entries, but that hasn't been consistent; usually we just create a tag. Is it required to create a Release entry in order for a tag to not be recognized as a prerelease? |
Per the discussion on Slack, I modified the |
Depend on tinyxml2 instead of tinyxml. Update `livecheck` block to check tags, aligning with upstream release process. Co-authored-by: Sam Ford <[email protected]>
🤖 An automated task has requested bottles to be published to this PR. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?This version of
urdfdom
now depends ontinyxml2
instead oftinyxml
.