Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a parsePose method in urdfdom 4.0.0 with the same signature as the function defined locally in urdf_world_parser, which causes build errors due to an ambiguous call. This adds
urdf_parsing::
to the reference toparsePose
to eliminate the ambiguity. Needed for Homebrew/homebrew-core#158963.I was confused about why this error occurs since I don't see
using namespace urdf;
anywhere, but I believe it's due to argument-dependent lookup (thanks @azeey for the pointer).Before creating a pull request
make format
-DDART_TREAT_WARNINGS_AS_ERRORS=ON
and resolve all the compile warningsBefore merging a pull request
CHANGELOG.md