Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with urdfdom 4.0.0 #1779

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

scpeters
Copy link
Collaborator

@scpeters scpeters commented Jan 4, 2024

There is a parsePose method in urdfdom 4.0.0 with the same signature as the function defined locally in urdf_world_parser, which causes build errors due to an ambiguous call. This adds urdf_parsing:: to the reference to parsePose to eliminate the ambiguity. Needed for Homebrew/homebrew-core#158963.

I was confused about why this error occurs since I don't see using namespace urdf; anywhere, but I believe it's due to argument-dependent lookup (thanks @azeey for the pointer).

Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

There is a parsePose method in urdfdom 4.0.0 with
the same signature as the function defined locally
in urdf_world_parser, which causes build errors
due to an ambiguous call. This adds urdf_parsing::
to eliminate the ambiguity.

Signed-off-by: Steve Peters <[email protected]>
@jslee02
Copy link
Member

jslee02 commented Jan 5, 2024

Thank you for the fix!

@jslee02 jslee02 merged commit 284772f into dartsim:release-6.13 Jan 5, 2024
0 of 2 checks passed
@jslee02 jslee02 added this to the DART 6.13.1 milestone Jan 5, 2024
@scpeters scpeters deleted the scpeters/fix_build_urdfdom4 branch January 5, 2024 00:20
@scpeters
Copy link
Collaborator Author

scpeters commented Jan 5, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants