Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urdfdom_headers: add livecheck #159093

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

samford
Copy link
Member

@samford samford commented Jan 5, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

As mentioned in #158963 (comment), urdfdom uses tags to indicate a new version, despite upstream having created a few GitHub releases in the past. This adds a livecheck block using the same approach (and comment) from #158963, to align urdfdom_headers.

livecheck already checks the Git tags for urdfdom_headers by default and returns 1.1.1 as the newest version but the matches also include a one-off h match (from the pass_through tag). Using the standard regex for Git tags like 1.2.3/v1.2.3 (/^v?(\d+(?:\.\d+)+)$/i) avoids that unwanted tag.

@samford samford added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Jan 5, 2024
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; thanks!

@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 5, 2024
Merged via the queue into Homebrew:master with commit 6619079 Jan 5, 2024
15 checks passed
@samford samford deleted the urdfdom_headers-add-livecheck branch January 6, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants