Skip to content

chore: upgrade wallet-lib to v2.5.1#222

Merged
r4mmer merged 38 commits intomasterfrom
feat/upgrade-wallet-lib-v2.1.1
Jul 17, 2025
Merged

chore: upgrade wallet-lib to v2.5.1#222
r4mmer merged 38 commits intomasterfrom
feat/upgrade-wallet-lib-v2.1.1

Conversation

@r4mmer
Copy link
Copy Markdown
Member

@r4mmer r4mmer commented Mar 25, 2025 •
edited
Loading

Acceptance Criteria

  • Upgrade wallet-lib version to 2.5.1

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer self-assigned this Mar 25, 2025
@r4mmer r4mmer moved this from Todo to In Progress (WIP) in Hathor Network Mar 25, 2025
r4mmer added 25 commits March 25, 2025 13:32
@r4mmer
chore: upgrade yarn lock
925d526
@r4mmer
feat: turn authorities into bigint to compare with lib consts
ccd1daf
@r4mmer
feat: use node22
6c2eabe
@r4mmer
feat: change bigint support config on mysql client
4916bd3
@r4mmer
feat: add database support for bigint with type changes and error fixes
d684a44
@r4mmer
tests: fix issues caused by bigint support and typing
6dcf051
@r4mmer
chore: lockfile updates
332944c
@r4mmer
tests(daemon): expect bigint values
039b984
@r4mmer
tests: expect bigint values
004f851
@r4mmer
tests: use JSONBigInt where applicabel
fd9d9cf
@r4mmer
tests: expect bigint values
355d2de
@r4mmer
Merge remote-tracking branch 'origin/master' into feat/upgrade-wallet…
bd8b013 
…-lib-v2.1.1

* origin/master:
  fix: io decoded handling (#229)
  chore: bump version v1.8.0 (#226)
  fix: nft utils should be imported from common index (#223)
  fix: daemon was always using ssl regardless of config (#224)
@r4mmer
tests: expect bigint values
6f5dc26
@r4mmer
tests: expect bigint values
d81149c
@r4mmer
Merge remote-tracking branch 'origin/master' into feat/upgrade-wallet…
712b0c5 
…-lib-v2.1.1

* origin/master:
  chore: update lock file
  chore: bump wallet-lib v1.15.0
@r4mmer
chore: lock update
e392fd0
@r4mmer
Merge remote-tracking branch 'origin/master' into feat/upgrade-wallet…
859b795 
…-lib-v2.1.1

* origin/master:
  feat: error handler middleware (#234)
@r4mmer
Merge remote-tracking branch 'origin/master' into feat/upgrade-wallet…
2fa0a74 
…-lib-v2.1.1

* origin/master:
  chore: better eslint (#228)
@r4mmer
chore: lock update
2165e49
@r4mmer
Merge remote-tracking branch 'origin/master' into feat/upgrade-wallet…
496866e 
…-lib-v2.1.1

* origin/master:
  chore: bump v1.8.2 (#237)
  chore: bump v1.8.1
@r4mmer
chore: parse using JSONbigint
8e53fe9
@r4mmer
chore: parse using JSONbigint
b2f7e70
@r4mmer
chore: parse using JSONbigint
687cf2c
@r4mmer
chore: add bigint values instead of strings
68d9c3e
@r4mmer
chore: parse websocket event
058aa51
@r4mmer r4mmer moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Apr 11, 2025
r4mmer added 2 commits July 3, 2025 12:14
@r4mmer
Merge remote-tracking branch 'origin/master' into feat/upgrade-wallet…
fabef3a 
…-lib-v2.1.1

* origin/master:
  chore: bumped to v1.9.0 (#259)
  chore: nano-testnet-hackaton (#243)
  fix: address invalid parameter (#235)
  chore: added htr token seed (#256)
  fix: invalid assert in release tx proposal utxos (#251)
  fix: we should await mark utxos with proposal id to prevent a race condition (#250)
  Merge pull request #248 from HathorNetwork/feat/version-camel-case
  fix: v1.8.2-rc.3 qa issues (#246)
  fix: firebase env variables should be optional (#245)
  chore: remove error handler middleware from authorization lambda (#242)
  feat: version data validation (#241)
  fix: Mainnet release script (#203)
@r4mmer
chore: update to v2.5.1
08925be
@r4mmer r4mmer moved this from In Progress (Done) to In Progress (WIP) in Hathor Network Jul 3, 2025
@r4mmer r4mmer changed the title chore: upgrade wallet-lib to v2.1.1 chore: upgrade wallet-lib to v2.5.1 Jul 3, 2025
@r4mmer r4mmer moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Jul 3, 2025
andreabadesso
andreabadesso reviewed Jul 14, 2025
View reviewed changes
Comment thread packages/daemon/src/utils/cache.ts
Comment thread packages/wallet-service/tests/utils/pushnotification.utils.test.ts Outdated
pedroferreira1
pedroferreira1 reviewed Jul 14, 2025
View reviewed changes
Comment thread packages/daemon/src/actors/WebSocketActor.ts Outdated
Comment thread packages/daemon/src/types/event.ts

export interface EventTxOutput {
value: number;
value: bigint;
Copy link
Copy Markdown
Member

@pedroferreira1 pedroferreira1 Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a full node event? Does the value come as string?

Copy link
Copy Markdown
Member Author

@r4mmer r4mmer Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, I was changing instances of value to bigint and did not consider how the data is generated.
This comes from the reliable integration, so it is a json event from a fullnode websocket, maybe we should create zod schemas to parse and validate the event data.

Copy link
Copy Markdown
Member

@pedroferreira1 pedroferreira1 Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to do it in another PR. Can you create an issue so we can track this?

Copy link
Copy Markdown
Member Author

@r4mmer r4mmer Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created the issue #266 to track this

Comment thread packages/wallet-service/src/db/utils.ts
Comment on lines +155 to +157
function abs(num: bigint) {
return num >= 0n ? num : -num;
}
Copy link
Copy Markdown
Member

@pedroferreira1 pedroferreira1 Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You had to create this method twice already. Maybe we could have a util bigIntAbs for this. What do you think?

Copy link
Copy Markdown
Member Author

@r4mmer r4mmer Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did create 2 instances of this method, but both of these were inside a sortBalanceValueByAbsTotal which is a method that is duplicated on the wallet-service and daemon packages.

This issue is because some utilities should be moved to the common package to avoid duplicating code.
So I think we should move the sortBalanceValueByAbsTotal instead of the internal abs and this seems a little outside the scope of this PR which is already huge.

What do you think?

Copy link
Copy Markdown
Member

@pedroferreira1 pedroferreira1 Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Can you create an issue in this repo with this discussion so we can improve this?

Copy link
Copy Markdown
Member Author

@r4mmer r4mmer Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created issue

Comment thread packages/wallet-service/src/db/index.ts Outdated
Comment thread packages/wallet-service/src/types.ts
Comment thread packages/wallet-service/src/types.ts
@r4mmer r4mmer moved this from In Progress (Done) to In Review (Done) in Hathor Network Jul 15, 2025
This was referenced Jul 16, 2025
Open
Open
@r4mmer r4mmer moved this from In Review (Done) to In Progress (Done) in Hathor Network Jul 16, 2025
@r4mmer r4mmer requested a review from andreabadesso July 17, 2025 16:36
@r4mmer r4mmer moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jul 17, 2025
@andreabadesso andreabadesso moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Jul 17, 2025
@andreabadesso andreabadesso moved this from Waiting to be deployed to In Review (Done) in Hathor Network Jul 17, 2025
@r4mmer r4mmer merged commit 0f15833 into master Jul 17, 2025
1 check passed
@github-project-automation github-project-automation Bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jul 17, 2025
@r4mmer r4mmer deleted the feat/upgrade-wallet-lib-v2.1.1 branch July 17, 2025 18:50
r4mmer added a commit that referenced this pull request Jul 18, 2025
@r4mmer
Merge remote-tracking branch 'origin/master' into feat/ingest-nano-co…
40627c8 
…ntract-tx

* origin/master:
  chore: upgrade wallet-lib to v2.5.1 (#222)
@r4mmer r4mmer moved this from Waiting to be deployed to Done in Hathor Network Aug 21, 2025
This was referenced Nov 17, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@andreabadesso andreabadesso andreabadesso approved these changes

Assignees

@r4mmer r4mmer

Labels

None yet

Projects

Hathor Network
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@r4mmer @pedroferreira1 @andreabadesso