chore: better eslint#228
Merged
Merged
Conversation
r4mmer
approved these changes
Apr 2, 2025
41731e6 to
8e42f0f
Compare
tuliomir
approved these changes
Apr 7, 2025
| devshell = { | ||
| startup = { | ||
| setup.text = '' | ||
| export PATH="$PWD/node_modules/.bin:$PWD/packages/daemon/node_modules/.bin:$PWD/packages/wallet-service/node_modules/.bin:$PATH" |
Contributor
There was a problem hiding this comment.
question(non-blocking): While I think adding the .bin folder to the path is a smart move, maybe it relies too much on the internal implementation of NodeJS.
What is our actual need for this export? Couldn't we just replace our usage of those binaries with npx myDependency, since npx is available since npm 8?
Collaborator
Author
There was a problem hiding this comment.
Yea, the idea here is to have typescript available in the path, so the LSP from the dev editor can use it
This it good so we don't have to install typescript globally (using npm)
Also, we are using yarn in this repository, so we shouldn't use npm here
r4mmer
added a commit
that referenced
this pull request
Apr 7, 2025
…-lib-v2.1.1 * origin/master: chore: better eslint (#228)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The motivation for the changes in this PR is to fix ESLint issues in editors by ensuring each project gets the correct ESLint configuration. Currently, ESLint is failing because it is unable to correctly parse TypeScript files for each project.
Acceptance Criteria
Checklist