fix: nft utils should be imported from common index#223
Merged
andreabadesso merged 1 commit intomasterfrom Mar 26, 2025
Merged
Conversation
f297d76 to
c961af8
Compare
c961af8 to
e4ec7b2
Compare
tuliomir
approved these changes
Mar 26, 2025
r4mmer
approved these changes
Mar 26, 2025
2 tasks
r4mmer
added a commit
that referenced
this pull request
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Should fix Incident #229
Error: Cannot find module '@wallet-service/common/src/utils/nft.utils'Acceptance Criteria
processNftEventto the mocked NftUtils in services testsChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged