Skip to content

fix: nft utils should be imported from common index#223

Merged
andreabadesso merged 1 commit intomasterfrom
fix/nftutils-import
Mar 26, 2025
Merged

fix: nft utils should be imported from common index#223
andreabadesso merged 1 commit intomasterfrom
fix/nftutils-import

Conversation

@andreabadesso
Copy link
Copy Markdown
Collaborator

@andreabadesso andreabadesso commented Mar 26, 2025

Motivation

Should fix Incident #229

Error: Cannot find module '@wallet-service/common/src/utils/nft.utils'

Acceptance Criteria

  • Importing directly from src works in dev and tests but fails in the compiled version, we should import from the exported index
  • Added the processNftEvent to the mocked NftUtils in services tests

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Mar 26, 2025
@andreabadesso andreabadesso added the bug Something isn't working label Mar 26, 2025
@andreabadesso andreabadesso moved this from Todo to In Progress (Done) in Hathor Network Mar 26, 2025
@tuliomir tuliomir moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 26, 2025
@andreabadesso andreabadesso merged commit 239b5a7 into master Mar 26, 2025
1 check passed
@andreabadesso andreabadesso deleted the fix/nftutils-import branch March 26, 2025 15:21
@github-project-automation github-project-automation Bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Mar 26, 2025
@r4mmer r4mmer mentioned this pull request Apr 1, 2025
2 tasks
r4mmer added a commit that referenced this pull request Apr 2, 2025
…-lib-v2.1.1

* origin/master:
  fix: io decoded handling (#229)
  chore: bump version v1.8.0 (#226)
  fix: nft utils should be imported from common index (#223)
  fix: daemon was always using ssl regardless of config (#224)
@r4mmer r4mmer moved this from Waiting to be deployed to Done in Hathor Network Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants