Skip to content

fix: Mainnet release script#203

Merged
luislhl merged 2 commits intoreleasefrom
fix/mainnet-release
Dec 12, 2024
Merged

fix: Mainnet release script#203
luislhl merged 2 commits intoreleasefrom
fix/mainnet-release

Conversation

@luislhl
Copy link
Copy Markdown
Collaborator

@luislhl luislhl commented Dec 12, 2024

Motivation

We were getting an error during the CI/CD flow:

bash scripts/build-daemon.sh
Please export a ACCOUNT_ID env var before running this
make: *** [Makefile:7: build-daemon] Error 1

Acceptance Criteria

  • The env vars should be exported when running make build-daemon in the deploy script.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@luislhl luislhl self-assigned this Dec 12, 2024
tuliomir
tuliomir approved these changes Dec 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@tuliomir tuliomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(non-blocking): Since we're making two separate deploys, why not make two separate calls to send_slack_message, one for each deploy?

@luislhl luislhl merged commit c643e27 into release Dec 12, 2024
@luislhl luislhl deleted the fix/mainnet-release branch December 12, 2024 16:03
r4mmer added a commit that referenced this pull request Jul 3, 2025
@r4mmer
Merge remote-tracking branch 'origin/master' into feat/upgrade-wallet…
fabef3a 
…-lib-v2.1.1

* origin/master:
  chore: bumped to v1.9.0 (#259)
  chore: nano-testnet-hackaton (#243)
  fix: address invalid parameter (#235)
  chore: added htr token seed (#256)
  fix: invalid assert in release tx proposal utxos (#251)
  fix: we should await mark utxos with proposal id to prevent a race condition (#250)
  Merge pull request #248 from HathorNetwork/feat/version-camel-case
  fix: v1.8.2-rc.3 qa issues (#246)
  fix: firebase env variables should be optional (#245)
  chore: remove error handler middleware from authorization lambda (#242)
  feat: version data validation (#241)
  fix: Mainnet release script (#203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuliomir tuliomir tuliomir approved these changes

@andreabadesso andreabadesso andreabadesso approved these changes

Assignees

@luislhl luislhl

Labels

None yet

Projects

Hathor Network
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luislhl @tuliomir @andreabadesso