Merged
Conversation
andreabadesso
force-pushed
the
fix/address-invalid-parameter
branch
from
34046cd to
6e3feb9
Compare
andreabadesso
moved this from In Progress (Done)
to In Progress (WIP)
in Hathor Network
andreabadesso
moved this from In Progress (WIP)
to In Progress (Done)
in Hathor Network
andreabadesso
force-pushed
the
fix/address-invalid-parameter
branch
from
945701a to
32c72f8
Compare
andreabadesso
commented
Apr 16, 2025
Comment on lines
-327
to
-330
| request: | ||
| parameters: | ||
| paths: | ||
| index: false |
Collaborator
Author
There was a problem hiding this comment.
We would only need this block if we wanted to enforce the presence of a specific query in api gateway, which is not the case
andreabadesso
moved this from In Progress (Done)
to In Progress (WIP)
in Hathor Network
r4mmer
reviewed
Apr 29, 2025
pedroferreira1
previously approved these changes
Apr 30, 2025
andreabadesso
moved this from In Progress (WIP)
to In Progress (Done)
in Hathor Network
r4mmer
approved these changes
Apr 30, 2025
pedroferreira1
approved these changes
Apr 30, 2025
github-project-automation
Bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
r4mmer
added a commit
that referenced
this pull request
Jul 3, 2025
…-lib-v2.1.1 * origin/master: chore: bumped to v1.9.0 (#259) chore: nano-testnet-hackaton (#243) fix: address invalid parameter (#235) chore: added htr token seed (#256) fix: invalid assert in release tx proposal utxos (#251) fix: we should await mark utxos with proposal id to prevent a race condition (#250) Merge pull request #248 from HathorNetwork/feat/version-camel-case fix: v1.8.2-rc.3 qa issues (#246) fix: firebase env variables should be optional (#245) chore: remove error handler middleware from authorization lambda (#242) feat: version data validation (#241) fix: Mainnet release script (#203)
This was referenced Nov 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The motivation for these changes was to correct the handling of the
indexparameter in the/addressesAPI endpoint.Previously, the
indexwas incorrectly fetched from path parameters, causing all requests withindexto be ignored and a list of addresses instead of the queried oneAcceptance Criteria
/addressesendpoint should accept theindexparameter as a query string parameter, not as a path parameter.indexis omitted, all addresses for the wallet should be returned.indexis provided, only the address at that index should be returned.indexChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged