intTests: Stop using the find-java-rt-jar.sh script #1061
Labels
subsystem: crucible-jvm
Issues related to Java verification with crucible-jvm
tooling: test infrastructure
Issues involving test infrastructure or test execution, or making SAW more testable
Comments
RyanGlScott
added
subsystem: crucible-jvm
RyanGlScott
added a commit
that referenced
this issue
Feb 5, 2021
* Remove the use of the `find-java-rt-jar.sh` script in CI, as this is no longer necessary with the advent of `--java-bin-dirs`/searching the `PATH` for Java. This fixes #1061. * On a related note, it turns out that SAW's approach to detecting where `rt.jar` lives likely doesn't work on pre-7 JDKs on macOS. Given how ancient these versions of Java anymore, let's just document this infelicity in the manual and describe a workaround for those brave enough to try this. Fixes #1062.
RyanGlScott
added a commit
that referenced
this issue
Feb 8, 2021
* Remove the use of the `find-java-rt-jar.sh` script in CI, as this is no longer necessary with the advent of `--java-bin-dirs`/searching the `PATH` for Java. This fixes #1061. * Now that `find-java-rt-jar.sh` is gone, there is no longer any need for the `.github/PropertiesTest.java` utility, nor is there any need for the `find_java` bash function that leverages this. This patch remove both of them as well. * On a related note, it turns out that SAW's approach to detecting where `rt.jar` lives likely doesn't work on pre-7 JDKs on macOS. Given how ancient these versions of Java anymore, let's just document this infelicity in the manual and describe a workaround for those brave enough to try this. Fixes #1062.
RyanGlScott
added a commit
that referenced
this issue
Feb 11, 2021
* Remove the use of the `find-java-rt-jar.sh` script in CI, as this is no longer necessary with the advent of `--java-bin-dirs`/searching the `PATH` for Java. This fixes #1061. * Now that `find-java-rt-jar.sh` is gone, there is no longer any need for the `.github/PropertiesTest.java` utility, nor is there any need for the `find_java` bash function that leverages this. This patch remove both of them as well. * On a related note, it turns out that SAW's approach to detecting where `rt.jar` lives likely doesn't work on pre-7 JDKs on macOS. Given how ancient these versions of Java anymore, let's just document this infelicity in the manual and describe a workaround for those brave enough to try this. Fixes #1062.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the integration tests use a hacky script to locate the location of
rt.jarin a Java installation:saw-script/intTests/runtests.sh
Line 42 in f8449a1
This really shouldn't be required, however, as
saw-scriptgained the ability to locatert.jarautomatically in #1030 by way of the--java-bin-dirsflag—or, equivalently, by puttingjavaon thePATH. Moreover, CI does in fact putjavaon thePATH, which makes the use offind-java-rt-jar.shobsolete in theory. We should confirm that this is the case in practice, and if so, stop using it.The text was updated successfully, but these errors were encountered: