Remove find-java-rt-jar.sh, document how -b interacts with older JDKs #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
force-pushed
the
java-bin-dirs-tweaks
branch
from
a9e9997 to
bcfe003
Compare
atomb
approved these changes
Feb 11, 2021
* Remove the use of the `find-java-rt-jar.sh` script in CI, as this is no longer necessary with the advent of `--java-bin-dirs`/searching the `PATH` for Java. This fixes #1061. * Now that `find-java-rt-jar.sh` is gone, there is no longer any need for the `.github/PropertiesTest.java` utility, nor is there any need for the `find_java` bash function that leverages this. This patch remove both of them as well. * On a related note, it turns out that SAW's approach to detecting where `rt.jar` lives likely doesn't work on pre-7 JDKs on macOS. Given how ancient these versions of Java anymore, let's just document this infelicity in the manual and describe a workaround for those brave enough to try this. Fixes #1062.
RyanGlScott
force-pushed
the
java-bin-dirs-tweaks
branch
from
bcfe003 to
56161cd
Compare
RyanGlScott
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of the
find-java-rt-jar.shscript in CI, as this is no longer necessary with the advent of--java-bin-dirs/searching thePATHfor Java. This fixes intTests: Stop using the find-java-rt-jar.sh script #1061.Now that
find-java-rt-jar.shis gone, there is no longer any need for the.github/PropertiesTest.javautility, nor is there any need for thefind_javabash function that leverages this. This patch removes both of them as well.On a related note, it turns out that SAW's approach to detecting where
rt.jarlives likely doesn't work on pre-7 JDKs on macOS. Given how ancient these versions of Java anymore, let's just document this infelicity in the manual and describe a workaround for those brave enough to try this. Fixes Automatic rt.jar detection is likely incorrect on macOS for pre-7 versions of the JDK #1062.