Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on jvm-verifier repository #1060

Merged
merged 4 commits into from
Feb 4, 2021

Conversation

brianhuffman
Copy link
Contributor

This removes some of the few remaining dependencies on the
jvm-verifier repository.

This removes some of the few remaining dependencies on the
jvm-verifier repository.
@RyanGlScott
Copy link
Contributor

Hooray!

There are a number of lingering referenced to jvm-verifier and jss that are now obsolete:

echo "constraints: jvm-verifier -builtin-abc, cryptol-saw-core -build-css" >> cabal.project.local

saw-script/.gitmodules

Lines 16 to 18 in 1467987

[submodule "deps/jvm-verifier"]
path = deps/jvm-verifier
url = https://github.com/GaloisInc/jvm-verifier.git

https://github.com/GaloisInc/saw-script/blob/14679870c91c53cf6f4470143cee34b7a8952933/README.md#related-packages

https://github.com/GaloisInc/saw-script/blob/14679870c91c53cf6f4470143cee34b7a8952933/intTests/test0018_jss_class_load/README

# https://github.com/GaloisInc/jvm-verifier/issues/3 is not fixed,

export JSS="eval cabal run ${CABAL_FLAGS} jss -- -j '$CP' -c ."

@brianhuffman
Copy link
Contributor Author

I have commits for all those other things lined up, but I just wanted to check that CI passes at each step.

@brianhuffman brianhuffman force-pushed the remove-jvm-verifier branch 2 times, most recently from 2ab0b3e to 75f0190 Compare February 4, 2021 17:50
@brianhuffman brianhuffman marked this pull request as ready for review February 4, 2021 18:45
@brianhuffman brianhuffman requested a review from atomb February 4, 2021 18:46
@brianhuffman
Copy link
Contributor Author

It looks like the CI tests are working so far, so I think this is ready for review.

With the removal of the jss-related portion of the test, the
original name no longer fits.
Copy link
Contributor

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@brianhuffman brianhuffman merged commit f8449a1 into master Feb 4, 2021
@mergify mergify bot deleted the remove-jvm-verifier branch February 4, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants